You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/17 17:28:19 UTC

[GitHub] [cordova-plugin-statusbar] breautek edited a comment on issue #171: [do not merge yet](android) Read config.xml for statusbar overlay preference

breautek edited a comment on issue #171: [do not merge yet](android) Read config.xml for statusbar overlay preference
URL: https://github.com/apache/cordova-plugin-statusbar/pull/171#issuecomment-554767602
 
 
   > Not a big thing since you are putting the default value in the code, but the default preferences are usually put in the plugin.xml too so they are written to the resulting `config.xml`. (like this for iOS https://github.com/apache/cordova-plugin-statusbar/blob/master/plugin.xml#L61)
   
   Was unaware of this. Another thing to learn. I'll make this change in a bit for consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org