You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2022/10/26 15:59:36 UTC
[camel] branch main updated (04ea1633ae2 -> ba422717c59)
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
from 04ea1633ae2 (chores) camel-aws2-kinesis: renamed variable to avoid conflicts with restricted identifiers
new 9c1a13517a5 (chores) camel-aws2-athena: avoid shadowing member variables
new ba422717c59 (chores) camel-facebook: avoid unnecessary object instantiation
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../apache/camel/component/aws2/athena/Athena2Component.java | 10 +++++-----
.../camel/component/facebook/data/FacebookMethodsType.java | 6 +++---
2 files changed, 8 insertions(+), 8 deletions(-)
[camel] 02/02: (chores) camel-facebook: avoid unnecessary object instantiation
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit ba422717c5966c4ea50ed4e1ffbb6c5329888573
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Oct 26 16:41:45 2022 +0200
(chores) camel-facebook: avoid unnecessary object instantiation
---
.../apache/camel/component/facebook/data/FacebookMethodsType.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/components/camel-facebook/src/main/java/org/apache/camel/component/facebook/data/FacebookMethodsType.java b/components/camel-facebook/src/main/java/org/apache/camel/component/facebook/data/FacebookMethodsType.java
index a8ed0898b16..1b726c4c69f 100644
--- a/components/camel-facebook/src/main/java/org/apache/camel/component/facebook/data/FacebookMethodsType.java
+++ b/components/camel-facebook/src/main/java/org/apache/camel/component/facebook/data/FacebookMethodsType.java
@@ -172,7 +172,7 @@ public enum FacebookMethodsType {
// DomainMethods
GETDOMAIN(Domain.class, "getDomain", String.class, "domainId"),
GETDOMAINBYNAME(Domain.class, "getDomainByName", String.class, "domainName"),
- GETDOMAINSBYNAME_WITH_DOMAINS(List.class, "getDomainsByName", new String[0].getClass(), "domainNames"),
+ GETDOMAINSBYNAME_WITH_DOMAINS(List.class, "getDomainsByName", String[].class, "domainNames"),
// EventMethods
CREATEEVENT(String.class, "createEvent", EventUpdate.class, "eventUpdate"),
@@ -210,7 +210,7 @@ public enum FacebookMethodsType {
GETRSVPSTATUSINMAYBE(ResponseList.class, "getRSVPStatusInMaybe", String.class, "eventId"),
GETRSVPSTATUSINMAYBE_WITH_ID(ResponseList.class, "getRSVPStatusInMaybe", String.class, "eventId", String.class, "userId"),
INVITETOEVENT(Boolean.class, "inviteToEvent", String.class, "eventId", String.class, "userId"),
- INVITETOEVENT_WITH_IDS(Boolean.class, "inviteToEvent", String.class, "eventId", new String[0].getClass(), "userIds"),
+ INVITETOEVENT_WITH_IDS(Boolean.class, "inviteToEvent", String.class, "eventId", String[].class, "userIds"),
POSTEVENTLINK_WITH_LINK(String.class, "postEventLink", String.class, "eventId", URL.class, "link"),
POSTEVENTLINK_WITH_LINK_MSG(String.class, "postEventLink", String.class, "eventId", URL.class, "link", String.class,
"message"),
@@ -616,7 +616,7 @@ public enum FacebookMethodsType {
GETSSLPICTUREURL_WITH_ID_SIZE(URL.class, "getSSLPictureURL", String.class, "userId", PictureSize.class, "size"),
GETUSER(User.class, "getUser", String.class, "userId"),
GETUSER_WITH_OPTIONS(User.class, "getUser", String.class, "userId", Reading.class, FacebookConstants.READING_PROPERTY),
- GETUSERS(List.class, "getUsers", new String[0].getClass(), "ids"),
+ GETUSERS(List.class, "getUsers", String[].class, "ids"),
// VideoMethods
COMMENTVIDEO(String.class, "commentVideo", String.class, "videoId", String.class, "message"),
[camel] 01/02: (chores) camel-aws2-athena: avoid shadowing member variables
Posted by or...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 9c1a13517a54a0955e431cbcd6dcf964e549a21b
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Wed Oct 26 16:37:36 2022 +0200
(chores) camel-aws2-athena: avoid shadowing member variables
---
.../apache/camel/component/aws2/athena/Athena2Component.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/components/camel-aws/camel-aws2-athena/src/main/java/org/apache/camel/component/aws2/athena/Athena2Component.java b/components/camel-aws/camel-aws2-athena/src/main/java/org/apache/camel/component/aws2/athena/Athena2Component.java
index f2ebe27a207..661033ba2aa 100644
--- a/components/camel-aws/camel-aws2-athena/src/main/java/org/apache/camel/component/aws2/athena/Athena2Component.java
+++ b/components/camel-aws/camel-aws2-athena/src/main/java/org/apache/camel/component/aws2/athena/Athena2Component.java
@@ -47,13 +47,13 @@ public class Athena2Component extends DefaultComponent {
@Override
protected Endpoint createEndpoint(String uri, String remaining, Map<String, Object> parameters) throws Exception {
- Athena2Configuration configuration
+ Athena2Configuration configurationClone
= this.configuration != null ? this.configuration.copy() : new Athena2Configuration();
- Athena2Endpoint endpoint = new Athena2Endpoint(uri, this, configuration);
+ Athena2Endpoint endpoint = new Athena2Endpoint(uri, this, configurationClone);
setProperties(endpoint, parameters);
- if (!configuration.isUseDefaultCredentialsProvider() && configuration.getAmazonAthenaClient() == null
- && (configuration.getAccessKey() == null
- || configuration.getSecretKey() == null)) {
+ if (!configurationClone.isUseDefaultCredentialsProvider() && configurationClone.getAmazonAthenaClient() == null
+ && (configurationClone.getAccessKey() == null
+ || configurationClone.getSecretKey() == null)) {
throw new IllegalArgumentException(
"useDefaultCredentialsProvider is set to false, accessKey/secretKey or amazonAthenaClient must be specified");
}