You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Rene Gielen (Created) (JIRA)" <ji...@apache.org> on 2012/02/28 01:15:52 UTC
[jira] [Created] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
XWork ContainerImpl causes ThreadLocal memory leak
--------------------------------------------------
Key: WW-3768
URL: https://issues.apache.org/jira/browse/WW-3768
Project: Struts 2
Issue Type: Bug
Components: Core Actions
Affects Versions: 2.3.1.2
Reporter: Rene Gielen
Assignee: Rene Gielen
Fix For: 2.3.2
The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236081#comment-13236081 ]
Hudson commented on WW-3768:
----------------------------
Integrated in Struts2 #435 (See [https://builds.apache.org/job/Struts2/435/])
WW-3768:
ThreadLocal was created but not removed appropriately (Revision 1304070)
Result = SUCCESS
rgielen :
Files :
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/inject/ContainerImpl.java
> XWork ContainerImpl causes ThreadLocal memory leak
> --------------------------------------------------
>
> Key: WW-3768
> URL: https://issues.apache.org/jira/browse/WW-3768
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.1.2
> Reporter: Rene Gielen
> Assignee: Rene Gielen
> Fix For: 2.3.2
>
>
> The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
Posted by "Rene Gielen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236066#comment-13236066 ]
Rene Gielen commented on WW-3768:
---------------------------------
The ThreadLocal is removed now, and after careful consideration it should be correct that way.
Nevertheless, please crosscheck since there is next to no automated testing possibility for this issue.
> XWork ContainerImpl causes ThreadLocal memory leak
> --------------------------------------------------
>
> Key: WW-3768
> URL: https://issues.apache.org/jira/browse/WW-3768
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.1.2
> Reporter: Rene Gielen
> Assignee: Rene Gielen
> Fix For: 2.3.2
>
>
> The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236443#comment-13236443 ]
Lukasz Lenart commented on WW-3768:
-----------------------------------
It looks ok for me, I've tested struts2-showcase application with Apache Tomcat/7.0.19, deploy, undeploy, redeploy - everything went smoothly, without warnings. JConsole showed normal memory consumption, I mean when I'd undeployed the application memory usage went down, redeployed went up and so on.
> XWork ContainerImpl causes ThreadLocal memory leak
> --------------------------------------------------
>
> Key: WW-3768
> URL: https://issues.apache.org/jira/browse/WW-3768
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.1.2
> Reporter: Rene Gielen
> Assignee: Rene Gielen
> Fix For: 2.3.2
>
>
> The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
Posted by "Lukasz Lenart (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236063#comment-13236063 ]
Lukasz Lenart commented on WW-3768:
-----------------------------------
Is it solved by the last commit ?
> XWork ContainerImpl causes ThreadLocal memory leak
> --------------------------------------------------
>
> Key: WW-3768
> URL: https://issues.apache.org/jira/browse/WW-3768
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.1.2
> Reporter: Rene Gielen
> Assignee: Rene Gielen
> Fix For: 2.3.2
>
>
> The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WW-3768) XWork ContainerImpl causes ThreadLocal
memory leak
Posted by "Rene Gielen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WW-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rene Gielen resolved WW-3768.
-----------------------------
Resolution: Fixed
The issue should be fixed. If problems arise, we should re-open it.
> XWork ContainerImpl causes ThreadLocal memory leak
> --------------------------------------------------
>
> Key: WW-3768
> URL: https://issues.apache.org/jira/browse/WW-3768
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.1.2
> Reporter: Rene Gielen
> Assignee: Rene Gielen
> Fix For: 2.3.2
>
>
> The localContext ThreadLocal is not cleaned up properly when stopping / undeploying / redeploying a S2 application. This will in most cases cause the web application ClassLoader not to be garbage collected, thus leaving a redeployment memory leak.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira