You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2026/07/04 10:09:37 UTC
[PR] fix(a11y): add aria-label to CRON schedule input [superset]
eschutho opened a new pull request, #41769:
URL: https://github.com/apache/superset/pull/41769
### WCAG rule
2.1 SC 1.3.1 (Info and Relationships) / 3.3.2 (Labels or Instructions) — Level A.
### What changed
The CRON expression text input in `AlertReportCronScheduler` (shown when a user picks "CRON Schedule" for an alert/report) had no `aria-label`, `aria-labelledby`, or associated `<label>`. Its only hint was a placeholder (`t('CRON expression')`) plus a visually adjacent but unassociated `<div className="control-label">` reading "Schedule". Screen reader users tabbing into the field heard no accessible name at all.
Added `aria-label={t('Schedule')}` to the `<Input>`, matching the naming convention already used by the sibling `Select` above it (`ariaLabel={t('Schedule type')}`, mirroring its own adjacent visible label).
### Behavior
No visual or functional change — this only adds an accessible name for assistive technology.
### Test plan
1. Open Alerts & Reports → create/edit an alert → in the "Schedule" section, switch schedule type to "CRON Schedule".
2. Tab to the CRON expression input with a screen reader running (e.g. VoiceOver/NVDA).
3. Verify the announced label is "Schedule" (previously: no accessible name announced, or generic "edit text").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): add aria-label to CRON schedule input [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #41769:
URL: https://github.com/apache/superset/pull/41769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): add aria-label to CRON schedule input [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41769:
URL: https://github.com/apache/superset/pull/41769#issuecomment-4881572592
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(a11y): add aria-label to CRON schedule input [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41769:
URL: https://github.com/apache/superset/pull/41769#issuecomment-4884919963
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41769?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.66%. Comparing base ([`687fafd`](https://app.codecov.io/gh/apache/superset/commit/687fafd424b7c96885f52d0c50ae31b7732f7e59?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ed82acf`](https://app.codecov.io/gh/apache/superset/commit/ed82acfec64ea8a2d4809d27a96d9882556162af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41769 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 2685 2685
Lines 148593 148593
Branches 34282 34282
=======================================
Hits 96088 96088
Misses 50740 50740
Partials 1765 1765
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41769/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/41769/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.50% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41769?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org