[GitHub] [lucene-solr] mikemccand commented on a change in pull request #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values

[GitBox <gi...@apache.org>]

mikemccand commented on a change in pull request #831: LUCENE-8949: Allow LeafFieldComparators to publish Feature Values
URL: https://github.com/apache/lucene-solr/pull/831#discussion_r315228534
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/LeafFieldComparator.java
 ##########
 @@ -116,4 +116,7 @@
    * obtain the current hit's score, if necessary. */
   void setScorer(Scorable scorer) throws IOException;
 
+  /** Publishes feature values for the given docID
+   */
+  T leafValue(int doc) throws IOException;
 
 Review comment:
   Maybe rename to `getDocValue`?  Can you expand the javadocs to state that the provided `doc` must only go forward?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org