You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Shatzer, Larry" <La...@Spirent.com> on 2004/05/17 16:16:51 UTC
[PATCH] add --targets to some subcommands that are missing them.
If any of these don't quite work with target, please remove them from the
list.
LOG:
* subversion/clients/cmdline/main.c: Added --targets to the following
diff, propdel, propedit, propget, proplist, status, switch, and update
Re: [PATCH] add --targets to some subcommands that are missing them.
Posted by Michael W Thelen <th...@cs.utah.edu>.
* kfogel@collab.net <kf...@collab.net> [2004-05-17 11:43]:
> "Shatzer, Larry" <La...@Spirent.com> writes:
> > If any of these don't quite work with target, please remove them from the
> > list.
>
> Thanks! The list of commands looks good to me.
>
> Quick question: did you run the test suite to see if getopt_tests
> needs to be adjusted for this? (I haven't, I just know that this is
> often a gotcha with adding options...)
I just ran the test suite with this patch applied, and getopt_tests
reported failure. So it looks like that would have to be updated as
well. Even so, I've filed this as a patch issue so it won't get lost:
http://subversion.tigris.org/issues/show_bug.cgi?id=1921
-- Mike
--
Michael W. Thelen
Civilization advances by extending the number of important operations we can
perform without thinking.
-- Alfred North Whitehead
Re: [PATCH] add --targets to some subcommands that are missing them.
Posted by kf...@collab.net.
"Shatzer, Larry" <La...@Spirent.com> writes:
> If any of these don't quite work with target, please remove them from the
> list.
Thanks! The list of commands looks good to me.
Quick question: did you run the test suite to see if getopt_tests
needs to be adjusted for this? (I haven't, I just know that this is
often a gotcha with adding options...)
I assume you tested the new functionality itself, of course :-).
-Karl
> LOG:
>
> * subversion/clients/cmdline/main.c: Added --targets to the following
> diff, propdel, propedit, propget, proplist, status, switch, and update
>
>
>
> Index: subversion/clients/cmdline/main.c
> ===================================================================
> --- subversion/clients/cmdline/main.c (revision 9745)
> +++ subversion/clients/cmdline/main.c (working copy)
> @@ -279,7 +279,7 @@
> {'r', svn_cl__old_cmd_opt, svn_cl__new_cmd_opt, 'x', 'N',
> svn_cl__diff_cmd_opt, svn_cl__no_diff_deleted,
> svn_cl__notice_ancestry_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "export", svn_cl__export, {0},
> N_("Create an unversioned copy of a tree.\n"
> @@ -456,7 +456,7 @@
> " 1. Removes versioned props in working copy.\n"
> " 2. Removes unversioned remote prop on repos revision.\n"),
> {'q', 'R', 'r', svn_cl__revprop_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "propedit", svn_cl__propedit, {"pedit", "pe"},
> N_("Edit property PROPNAME with an external editor on targets.\n"
> @@ -467,7 +467,7 @@
> " 2. Edits unversioned remote prop on repos revision.\n"),
> {'r', svn_cl__revprop_opt, SVN_CL__AUTH_OPTIONS,
> svn_cl__encoding_opt, svn_cl__editor_cmd_opt, svn_cl__force_opt,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "propget", svn_cl__propget, {"pget", "pg"},
> N_("Print value of PROPNAME on files, dirs, or revisions.\n"
> @@ -484,7 +484,7 @@
> " the --strict option to disable these beautifications (useful,\n"
> " for example, when redirecting binary property values to a file).\n"),
> {'R', 'r', svn_cl__revprop_opt, svn_cl__strict_opt,
> - SVN_CL__AUTH_OPTIONS, svn_cl__config_dir_opt} },
> + SVN_CL__AUTH_OPTIONS, svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "proplist", svn_cl__proplist, {"plist", "pl"},
> N_("List all properties on files, dirs, or revisions.\n"
> @@ -494,7 +494,7 @@
> " 1. Lists versioned props in working copy.\n"
> " 2. Lists unversioned remote props on repos revision.\n"),
> {'v', 'R', 'r', 'q', svn_cl__revprop_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "propset", svn_cl__propset, {"pset", "ps"},
> N_("Set PROPNAME to PROPVAL on files, dirs, or revisions.\n"
> @@ -623,7 +623,7 @@
> " 965 687 joe wc/zig.c\n"
> " Head revision: 981\n"),
> { 'u', 'v', 'N', 'q', svn_cl__no_ignore_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "switch", svn_cl__switch, {"sw"},
> N_("Update the working copy to a different URL.\n"
> @@ -644,7 +644,7 @@
> "same\n"
> " directory within the same repository.\n"),
> { 'r', 'N', 'q', svn_cl__merge_cmd_opt, svn_cl__relocate_opt,
> - SVN_CL__AUTH_OPTIONS, svn_cl__config_dir_opt} },
> + SVN_CL__AUTH_OPTIONS, svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { "update", svn_cl__update, {"up"},
> N_("Bring changes from the repository into the working copy.\n"
> @@ -668,7 +668,7 @@
> " while updates to the file's properties are shown in the second "
> "column.\n"),
> {'r', 'N', 'q', svn_cl__merge_cmd_opt, SVN_CL__AUTH_OPTIONS,
> - svn_cl__config_dir_opt} },
> + svn_cl__config_dir_opt, svn_cl__targets_opt} },
>
> { NULL, NULL, {0}, NULL, {0} }
> };
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org