You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rodent of Unusual Size <co...@decus.org> on 1997/11/26 17:32:17 UTC
[PATCH] for #1479, #1480
I'm quite happy with enhancing the 'invalid command' message rather
than futzing with the logging of IfModules. How's the following for
proposed wording?
#ken P-)}
Index: main/http_config.c
===================================================================
RCS file: /export/home/cvs/apachen/src/main/http_config.c,v
retrieving revision 1.85
diff -u -r1.85 http_config.c
--- http_config.c 1997/11/06 20:40:42 1.85
+++ http_config.c 1997/11/26 16:26:21
@@ -804,8 +804,9 @@
do {
if (!(cmd = find_command_in_modules(cmd_name, &mod))) {
errno = EINVAL;
- return pstrcat(parms->pool, "Invalid command '", cmd_name, "'",
- NULL);
+ return pstrcat(parms->pool, "Invalid command '", cmd_name,
+ "', perhaps mis-spelled or defined by a module ",
+ "not included in the server configuration", NULL);
}
else {
void *mconfig = get_module_config(config, mod);
Re: [PATCH] for #1479, #1480
Posted by Martin Kraemer <Ma...@mch.sni.de>.
+1.
Martin
On Wed, Nov 26, 1997 at 11:32:17AM -0500, Rodent of Unusual Size wrote:
> I'm quite happy with enhancing the 'invalid command' message rather
> than futzing with the logging of IfModules. How's the following for
> proposed wording?
> + return pstrcat(parms->pool, "Invalid command '", cmd_name,
> + "', perhaps mis-spelled or defined by a module ",
-----and you could even omit that comma-------------------------------------->^
> + "not included in the server configuration", NULL);
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: [PATCH] for #1479, #1480
Posted by Dean Gaudet <dg...@arctic.org>.
+1
Dean
On Wed, 26 Nov 1997, Rodent of Unusual Size wrote:
> I'm quite happy with enhancing the 'invalid command' message rather
> than futzing with the logging of IfModules. How's the following for
> proposed wording?
>
> #ken P-)}
>
> Index: main/http_config.c
> ===================================================================
> RCS file: /export/home/cvs/apachen/src/main/http_config.c,v
> retrieving revision 1.85
> diff -u -r1.85 http_config.c
> --- http_config.c 1997/11/06 20:40:42 1.85
> +++ http_config.c 1997/11/26 16:26:21
> @@ -804,8 +804,9 @@
> do {
> if (!(cmd = find_command_in_modules(cmd_name, &mod))) {
> errno = EINVAL;
> - return pstrcat(parms->pool, "Invalid command '", cmd_name, "'",
> - NULL);
> + return pstrcat(parms->pool, "Invalid command '", cmd_name,
> + "', perhaps mis-spelled or defined by a module ",
> + "not included in the server configuration", NULL);
> }
> else {
> void *mconfig = get_module_config(config, mod);
>