[jira] Commented: (WICKET-870) ignore white space in web.xml filter, filtermapping

["Alastair Maw (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521762 ] 

Alastair Maw commented on WICKET-870:
-------------------------------------

Your patch [1] only trims the url pattern. Is this sufficient? Bug report claims this is required for filter name, servlet name, etc.

[1] http://svn.apache.org/viewvc?rev=568568&view=rev 

> ignore white space in web.xml filter, filtermapping
> ---------------------------------------------------
>
>                 Key: WICKET-870
>                 URL: https://issues.apache.org/jira/browse/WICKET-870
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta2
>         Environment: java1.5 / tomcat 5.0
>            Reporter: Stefan Wagner
>            Assignee: Jean-Baptiste Quenot
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>
> 1.3 does not ignore whitespace around xml tag content any more in <servlet-name>, <filter-name> and <url-pattern>
> More XML tags could be affected!
> Please change parsing or add a trim() in WicketFilter#getFilterPath for filterName, encounteredFilterName and urlPattern before searching matches with equals(), startsWith, endsWith:
> in WicketFilter.java line 483 
> 				if (filterName.equals(encounteredFilterName))
> 					urlPatterns.add(urlPattern);
>  in WicketFilter.java line 501
> 			// Check for leading '/' and trailing '*'.
> 			if (!urlPattern.startsWith("/") || !urlPattern.endsWith("*"))
> 			{
> 				throw new IllegalArgumentException("<" + mapping + "> for Wicket" + prefixUppered
> 						+ " \"" + filterName + "\" must start with '/' and end with '*'.");
> 			}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.