Re: Groovy integration tests

[Nicolas Malin <ni...@nereide.fr>]

I endorse the words,

I currently implement some new test for
https://issues.apache.org/jira/browse/OFBIZ-6988, and after 3 hours to
build ofbiz, it's really boring without clear most valuable.

If for technical best practice it's better to keep test compile, it's
possible when you test write is terminate to move the groovy-test-suite
to junit-test-suite, so no reason to remove the possibility to write
test as script.

Nicolas

On 08/09/2021 15:30, Gil Portenseigne wrote:
> Hello,
>
> Currently using release 18.12 for some project we got the habit to
> develop using integration test while developing in groovy.
>
> For that usage we use mainly :
>     groovy-test-suite
>
> That allow coding tests in groovy script that do not need to be compiled
> for their execution and executing them from webtools [1] (small
> improvement will be contributed soon), there is no need to reboot the
> local dev OFBiz instance for each modification in that test.
>
> But these type of test has been removed with OFBIZ-11165 [2], while I
> thinks that these resources are better compiled, during development
> process, not having to restart OFBiz is nice.
>
> So if nobody is against, I will reintroduce it in trunk with a note
> explaining the `dev` usage.
>
> WDYT
>
> Regards,
>
> Gil
>
> [1] https://localhost:8443/webtools/control/TestSuiteInfo
> [2] https://issues.apache.org/jira/browse/OFBIZ-11165

Re: Groovy integration tests

[Jacques Le Roux <ja...@les7arts.com>]

Hi Gil, Nicolas,

I agree it was a good thing to do. We just missed some information and documentation.
I have added some at OFBIZ-12320

I have also replaced all groovy-test-suite by junit-test-suite in OOTB code.

I still wonder why Eclipse proposes but does not accept groovy-test-suite as a right token and shows this message:

    <<Element name 'groovy-test-suite' is invalid.
    One of the following is expected:

      * TestCaseTypes

    Error indicated by:
    {the schema}
    with code:>>

when in https://ofbiz.apache.org/dtds/test-suite.xsd <https://ofbiz.apache.org/dtds/test-suite.xsd> there is no important
differences between junit-test-suite and groovy-test-suite definitions

Actually it's not too bad for committers. It makes you wonder and read the documentation. So learn that groovy-test-suite should better not used in 
production.

TIA

Jacques

Le 09/09/2021 à 09:43, Nicolas Malin a écrit :
> I endorse the words,
>
> I currently implement some new test for
> https://issues.apache.org/jira/browse/OFBIZ-6988, and after 3 hours to
> build ofbiz, it's really boring without clear most valuable.
>
> If for technical best practice it's better to keep test compile, it's
> possible when you test write is terminate to move the groovy-test-suite
> to junit-test-suite, so no reason to remove the possibility to write
> test as script.
>
> Nicolas
>
> On 08/09/2021 15:30, Gil Portenseigne wrote:
>> Hello,
>>
>> Currently using release 18.12 for some project we got the habit to
>> develop using integration test while developing in groovy.
>>
>> For that usage we use mainly :
>>      groovy-test-suite
>>
>> That allow coding tests in groovy script that do not need to be compiled
>> for their execution and executing them from webtools [1] (small
>> improvement will be contributed soon), there is no need to reboot the
>> local dev OFBiz instance for each modification in that test.
>>
>> But these type of test has been removed with OFBIZ-11165 [2], while I
>> thinks that these resources are better compiled, during development
>> process, not having to restart OFBiz is nice.
>>
>> So if nobody is against, I will reintroduce it in trunk with a note
>> explaining the `dev` usage.
>>
>> WDYT
>>
>> Regards,
>>
>> Gil
>>
>> [1]https://localhost:8443/webtools/control/TestSuiteInfo
>> [2]https://issues.apache.org/jira/browse/OFBIZ-11165