You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/01/11 08:32:34 UTC
Re: Review Request 54420: ATLAS-1352 : JS error while redirecting to
Knox gateway.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54420/#review161187
-----------------------------------------------------------
dashboardv2/public/js/utils/Utils.js (line 84)
<https://reviews.apache.org/r/54420/#comment232425>
how is error in JSON.parse() being handled?
dashboardv2/public/js/utils/Utils.js (line 85)
<https://reviews.apache.org/r/54420/#comment232424>
Shouldn't this be:
redirectURL!=undefined && redirectURL!=''
|| ==> &&
Please review.
- Madhan Neethiraj
On Dec. 6, 2016, 1:28 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54420/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 1:28 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1352
> https://issues.apache.org/jira/browse/ATLAS-1352
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provides fix for JS error while redirecting to Knox Url.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Utils.js 48963ad
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 75a884d
>
> Diff: https://reviews.apache.org/r/54420/diff/
>
>
> Testing
> -------
>
> Tested Atlas login after knox login enabled and disabled.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 54420: ATLAS-1352 : JS error while redirecting to
Knox gateway.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
> On Jan. 11, 2017, 8:32 a.m., Madhan Neethiraj wrote:
> > dashboardv2/public/js/utils/Utils.js, line 84
> > <https://reviews.apache.org/r/54420/diff/1/?file=1577718#file1577718line84>
> >
> > how is error in JSON.parse() being handled?
Added try catch to handle any parse error.
- Nixon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54420/#review161187
-----------------------------------------------------------
On Dec. 6, 2016, 1:28 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54420/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2016, 1:28 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1352
> https://issues.apache.org/jira/browse/ATLAS-1352
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provides fix for JS error while redirecting to Knox Url.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/Utils.js 48963ad
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 75a884d
>
> Diff: https://reviews.apache.org/r/54420/diff/
>
>
> Testing
> -------
>
> Tested Atlas login after knox login enabled and disabled.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>