You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/15 22:26:11 UTC
[GitHub] [spark] imback82 opened a new pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
imback82 opened a new pull request #29127:
URL: https://github.com/apache/spark/pull/29127
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to introduce `UnresolvedTableOrPermanentView` for commands that support a table and a permanent view, but not a temporary view as discussed here: https://github.com/apache/spark/pull/28375#discussion_r416343587.
This new logical plan is now used for `SHOW TBLPROPERTIES`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There are commands that support both a table and a permanent view, but not a temporary view. Using `UnresolvedTableOrPermanentView` makes it for the analyzer to resolve only the relation that's needed for those commands.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes,
Before:
```
scala> sql("CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1")
res0: org.apache.spark.sql.DataFrame = []
scala> sql("SHOW TBLPROPERTIES tv").show
+---+-----+
|key|value|
+---+-----+
+---+-----+
```
After:
```
scala> sql("CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1")
res0: org.apache.spark.sql.DataFrame = []
scala> sql("SHOW TBLPROPERTIES tv").show
org.apache.spark.sql.AnalysisException: tv is a temp view, not a table or permanent view.; line 1 pos 0
at org.apache.spark.sql.catalyst.analysis.package$AnalysisErrorAt.failAnalysis(package.scala:42)
at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTempViews$$anonfun$apply$7.$anonfun$applyOrElse$42(Analyzer.scala:863)
at scala.Option.foreach(Option.scala:407)
...
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Updated existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663299099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663298827
**[Test build #126446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126446/testReport)** for PR 29127 at commit [`933dc28`](https://github.com/apache/spark/commit/933dc28ed5a54e06d8125e51ae3c86e95760f21e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659200879
**[Test build #125923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125923/testReport)** for PR 29127 at commit [`a17696b`](https://github.com/apache/spark/commit/a17696b411d56b4fa8731462acb9a57dad1bb40e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class UnresolvedTableOrPermanentView(multipartIdentifier: Seq[String]) extends LeafNode `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663343111
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659093494
**[Test build #125923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125923/testReport)** for PR 29127 at commit [`a17696b`](https://github.com/apache/spark/commit/a17696b411d56b4fa8731462acb9a57dad1bb40e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659215915
cc: @cloud-fan @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29127: [SPARK-32327][SQL] SHOW TBLPROPERTIES is not allowed on temporary views
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663349227
> Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya
Sounds ok too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 closed pull request #29127: [SPARK-32327][SQL] SHOW TBLPROPERTIES is not allowed on temporary views
Posted by GitBox <gi...@apache.org>.
imback82 closed pull request #29127:
URL: https://github.com/apache/spark/pull/29127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663342083
Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663343111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659047837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-660137141
At first glance, I thought the PR description is confusing, because we can specify properties of temp view but can't display it. Then I realized that we just ignore the properties when creating temp views.
I think we should fail the temp view creating instead of silently ignoring the table properties when specified. @imback82 can you fix this first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663299099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29127:
URL: https://github.com/apache/spark/pull/29127#discussion_r456470950
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -42,14 +42,23 @@ case class UnresolvedTable(multipartIdentifier: Seq[String]) extends LeafNode {
}
/**
- * Holds the name of a table or view that has yet to be looked up in a catalog. It will
- * be resolved to [[ResolvedTable]] or [[ResolvedView]] during analysis.
+ * Holds the name of a table or a permanent/temporary view that has yet to be looked up in
+ * a catalog. It will be resolved to [[ResolvedTable]] or [[ResolvedView]] during analysis.
*/
case class UnresolvedTableOrView(multipartIdentifier: Seq[String]) extends LeafNode {
Review comment:
shall we simply add an `acceptTempView` flag here instead of adding `UnresolvedTableOrPermanentView`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659201682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #29127:
URL: https://github.com/apache/spark/pull/29127#discussion_r455567057
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -920,7 +920,7 @@ case class ShowTablePropertiesCommand(table: TableIdentifier, propertyKey: Optio
override def run(sparkSession: SparkSession): Seq[Row] = {
val catalog = sparkSession.sessionState.catalog
if (catalog.isTemporaryTable(table)) {
- Seq.empty[Row]
+ throw new AnalysisException(s"SHOW TBLPROPERTIES is not allowed on a temporary view: $table")
Review comment:
This will not be hit if you go thru `SHOW TBLPROPERTIES` command.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659047837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29127: [SPARK-32327][SQL] SHOW TBLPROPERTIES is not allowed on temporary views
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663823134
> Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya
I missed that.. yea, the decision sounds okay to me, too. Anyway, thanks for the work, @imback82 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659093494
**[Test build #125923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125923/testReport)** for PR 29127 at commit [`a17696b`](https://github.com/apache/spark/commit/a17696b411d56b4fa8731462acb9a57dad1bb40e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663343117
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126446/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663342831
**[Test build #126446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126446/testReport)** for PR 29127 at commit [`933dc28`](https://github.com/apache/spark/commit/933dc28ed5a54e06d8125e51ae3c86e95760f21e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-659201682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29127: [SPARK-32327][SQL] SHOW TBLPROPERTIES is not allowed on temporary views
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663351139
Yes, I agree. I will close this for now. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-660338281
> I think we should fail the temp view creating instead of silently ignoring the table properties when specified. @imback82 can you fix this first?
Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29127:
URL: https://github.com/apache/spark/pull/29127#issuecomment-663298827
**[Test build #126446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126446/testReport)** for PR 29127 at commit [`933dc28`](https://github.com/apache/spark/commit/933dc28ed5a54e06d8125e51ae3c86e95760f21e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org