You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/11/22 17:35:10 UTC

[GitHub] [phoenix] ss77892 commented on pull request #1357: PHOENIX-6601 Fix IndexTools bugs with namespace mapping

ss77892 commented on pull request #1357:
URL: https://github.com/apache/phoenix/pull/1357#issuecomment-975762029


   The way how the problem was addressed LGTM. As for the tests. There are a number of tests that are using IndexToolIT directly (usually runIndexTool method). Only one of those (IndexBuildTimestampIT) is calling setup for some purposes and that caused the compilation failure, but we might expect that others can be affected in some way as well. Not related to this particular patch, but some cleanup with the index-related IT tests needs to be done sometimes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org