You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/24 08:15:10 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #769: MINIFICPP-1203 - Remove --headers option when running "make linter"

hunyadi-dev opened a new pull request #769:
URL: https://github.com/apache/nifi-minifi-cpp/pull/769


   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm edited a comment on pull request #769: MINIFICPP-1203 - Remove --headers option when running "make linter"

Posted by GitBox <gi...@apache.org>.
szaszm edited a comment on pull request #769:
URL: https://github.com/apache/nifi-minifi-cpp/pull/769#issuecomment-619014515


   `build/include` means check that source files include their corresponding headers, e.g. A.cpp includes A.h
   With the `--headers` option removed, this breaks at least in standard-processors, cpplint is no longer able to tell that A.h corresponds to A.cpp, therefore emits a warning that the include is missing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #769: MINIFICPP-1203 - Remove --headers option when running "make linter"

Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on pull request #769:
URL: https://github.com/apache/nifi-minifi-cpp/pull/769#issuecomment-625200882


   Closing as #770 should contain more stable changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #769: MINIFICPP-1203 - Remove --headers option when running "make linter"

Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #769:
URL: https://github.com/apache/nifi-minifi-cpp/pull/769#issuecomment-619014515


   `-build/include` seems to be disabled because cpplint assumes incorrect include paths and doesn't recognize includes of corresponding headers. This seems to be caused by the removal of the `--headers` option.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org