You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:38:05 UTC
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #1125: build: exit normaly once catch 'make depend' failure case
liuguo09 opened a new pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125
# Summary
To be strict in check build, once any 'make depend' fails, exit normally.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-633862753
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691534462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] liuguo09 commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-692415472
> Your change is OK:
>
> > When a script ends with an exit that has no parameter, the exit status of the script is the exit status of the last command executed in the script (previous to the exit).
>
> So it is essentially the same as `false` in the context of a makefile
Ok, thanks your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691534462
@liuguo09 can you explain this PR again? I found this while looking for something else and from the changes it would appear that a mkdep call could fail and this would ignore the failure, since `exit` with no parameters does not generate a non-zero exit status. I believe this should be `false` not `exit`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#discussion_r430148869
##########
File path: tools/Makefile.unix
##########
@@ -437,12 +437,12 @@ download: $(BIN)
pass1dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
$(Q) for dir in $(USERDEPDIRS) ; do \
- $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" depend ; \
+ $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" depend || exit; \
done
pass2dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
$(Q) for dir in $(KERNDEPDIRS) ; do \
- $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)" depend; \
+ $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)" depend || exit; \
Review comment:
Let's add the same check to context at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#discussion_r430178754
##########
File path: tools/Makefile.unix
##########
@@ -437,12 +437,12 @@ download: $(BIN)
pass1dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
$(Q) for dir in $(USERDEPDIRS) ; do \
- $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" depend ; \
+ $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" depend || exit; \
done
pass2dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
$(Q) for dir in $(KERNDEPDIRS) ; do \
- $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)" depend; \
+ $(MAKE) -C $$dir TOPDIR="$(TOPDIR)" EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)" depend || exit; \
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691534462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-692164445
Your change is OK:
> When a script ends with an exit that has no parameter, the exit status of the script is the exit status of the last command executed in the script (previous to the exit).
So it is essentially the same as `false` in the context of a makefile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] liuguo09 commented on pull request #1125: build: exit normaly once catch 'make depend' failure case
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691857666
@v01d I remember there are cases that 'make -j4' still pass the full build even if there is mkdep fail issue. So add the exit into for loop to end it. As for using 'false' instead of 'exit', it seems reasonable, but I'm not very sure if it works well. We need reproduce the mkdep fail case and verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org