You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/12/22 18:47:00 UTC
[jira] [Commented] (DISPATCH-2299) re-enable system_tests_http delete listeners with libwebsockets >= 4.2
[ https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464004#comment-17464004 ]
ASF GitHub Bot commented on DISPATCH-2299:
------------------------------------------
jiridanek commented on a change in pull request #1468:
URL: https://github.com/apache/qpid-dispatch/pull/1468#discussion_r774096309
##########
File path: cmake/FindLibWebSockets.cmake
##########
@@ -45,10 +45,11 @@ find_path(LIBWEBSOCKETS_INCLUDE_DIRS
PATHS "/usr/include"
)
+# strips trailing version elaboration, e.g. #define LWS_LIBRARY_VERSION "4.1.6-git..."
if(LIBWEBSOCKETS_INCLUDE_DIRS AND EXISTS "${LIBWEBSOCKETS_INCLUDE_DIRS}/lws_config.h")
file(STRINGS "${LIBWEBSOCKETS_INCLUDE_DIRS}/lws_config.h" lws_version_str
REGEX "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"[^\"]+\"")
- string(REGEX REPLACE "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"([^\"]+)\".*" "\\1"
+ string(REGEX REPLACE "^#define[ \t]+LWS_LIBRARY_VERSION[ \t]+\"([0-9.]+).*" "\\1"
Review comment:
This is the cause that the test was not being run on CentOS 7. There, the `LWS_LIBRARY_VERSION` ended up being `3.0.1-`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> re-enable system_tests_http delete listeners with libwebsockets >= 4.2
> ----------------------------------------------------------------------
>
> Key: DISPATCH-2299
> URL: https://issues.apache.org/jira/browse/DISPATCH-2299
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Container
> Affects Versions: 1.18.0
> Reporter: Jiri Daněk
> Priority: Major
>
> The upstream issue in libwebsockets was fixed. The test can be reenabled
> # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html
> # https://github.com/warmcat/libwebsockets/issues/2327
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org