[GitHub] [arrow] avantgardnerio commented on a diff in pull request #33961: [GH-33475]: [flight-sql] Send prepared statement parameters

["avantgardnerio (via GitHub)" <gi...@apache.org>]

avantgardnerio commented on code in PR #33961:
URL: https://github.com/apache/arrow/pull/33961#discussion_r1092744601


##########
java/flight/flight-sql-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightPreparedStatement.java:
##########
@@ -93,6 +104,17 @@ public synchronized void close() throws SQLException {
 
   @Override
   public FlightInfo executeFlightInfoQuery() throws SQLException {
+    List<FieldVector> fields = new ArrayList<>();
+    for(int i = 0; i < this.getParameterCount(); i++) {
+      AvaticaParameter param = this.getParameter(i);
+      FieldVector v = switch (param.parameterType) {
+        case DECIMAL:
+          new DecimalVector()
+      };
+      FieldVector v = new
+    }
+    VectorSchemaRoot parameters = new VectorSchemaRoot();
+    this.preparedStatement.setParameters();

Review Comment:
   I think this is the missing piece. If we can translate the `AvaticaParameter`s into a `VectorSchemaRoot` the server will get what it needs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org