You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/04/04 02:33:42 UTC
Review Request 66416: HIVE-17647 DDLTask.generateAddMmTasks(Table
tbl) and other random code should not start transactions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66416/
-----------------------------------------------------------
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs
-----
itests/src/test/resources/testconfiguration.properties ec25713906
ql/src/java/org/apache/hadoop/hive/ql/Driver.java ed3984efe8
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java f53afaff2b
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 429c296dee
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitTask.java b3c62ad1a8
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitWork.java a119250464
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 10a2ed2663
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7470c8ae78
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 08d26dc14e
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 8b639f7922
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java 79b2e48ee2
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 3f82d16865
ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java 65f4cf233b
ql/src/test/results/clientpositive/mm_conversions.q.out 4754710291
Diff: https://reviews.apache.org/r/66416/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66416: HIVE-17647 DDLTask.generateAddMmTasks(Table
tbl) and other random code should not start transactions
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66416/#review201543
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
Lines 1436 (patched)
<https://reviews.apache.org/r/66416/#comment282841>
getTableWriteId() ensures you only allocate 1 write id per txn
- Eugene Koifman
On April 18, 2018, 4:16 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66416/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 4:16 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> itests/src/test/resources/testconfiguration.properties d26f0ccb17
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4acdd9b49b
> ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java f53afaff2b
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c8cb8a40b4
> ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitTask.java b3c62ad1a8
> ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitWork.java a119250464
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 10a2ed2663
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 4760b85da0
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 009a890888
> ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 85d1cff320
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 49a3464776
> ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java ac44be5e0b
> ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java bdecbaf144
> ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java d7b224772d
> ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java 65f4cf233b
> ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 0926663eab
> ql/src/test/results/clientpositive/mm_conversions.q.out 4754710291
>
>
> Diff: https://reviews.apache.org/r/66416/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 66416: HIVE-17647 DDLTask.generateAddMmTasks(Table
tbl) and other random code should not start transactions
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66416/
-----------------------------------------------------------
(Updated April 18, 2018, 11:16 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties d26f0ccb17
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4acdd9b49b
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java f53afaff2b
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c8cb8a40b4
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitTask.java b3c62ad1a8
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitWork.java a119250464
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 10a2ed2663
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 4760b85da0
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 009a890888
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 85d1cff320
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 49a3464776
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java ac44be5e0b
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java bdecbaf144
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java d7b224772d
ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java 65f4cf233b
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 0926663eab
ql/src/test/results/clientpositive/mm_conversions.q.out 4754710291
Diff: https://reviews.apache.org/r/66416/diff/4/
Changes: https://reviews.apache.org/r/66416/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66416: HIVE-17647 DDLTask.generateAddMmTasks(Table
tbl) and other random code should not start transactions
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66416/
-----------------------------------------------------------
(Updated April 18, 2018, 3:21 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties d26f0ccb17
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4acdd9b49b
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java f53afaff2b
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c8cb8a40b4
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitTask.java b3c62ad1a8
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitWork.java a119250464
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 10a2ed2663
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 4760b85da0
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 009a890888
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 85d1cff320
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 49a3464776
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java ac44be5e0b
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java bdecbaf144
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java d7b224772d
ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java 65f4cf233b
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 0926663eab
ql/src/test/results/clientpositive/mm_conversions.q.out 4754710291
Diff: https://reviews.apache.org/r/66416/diff/3/
Changes: https://reviews.apache.org/r/66416/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 66416: HIVE-17647 DDLTask.generateAddMmTasks(Table
tbl) and other random code should not start transactions
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66416/
-----------------------------------------------------------
(Updated April 5, 2018, 8:51 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
itests/src/test/resources/testconfiguration.properties d2e077b509
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 79db006c74
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java f53afaff2b
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java fb1efe01dc
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitTask.java b3c62ad1a8
ql/src/java/org/apache/hadoop/hive/ql/exec/ImportCommitWork.java a119250464
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 10a2ed2663
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eed37a1937
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 3e8e1b3981
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 9e66422904
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 8b639f7922
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java 79b2e48ee2
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java d7b224772d
ql/src/java/org/apache/hadoop/hive/ql/plan/DDLDesc.java 65f4cf233b
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java 8406caa761
ql/src/test/results/clientpositive/mm_conversions.q.out 4754710291
Diff: https://reviews.apache.org/r/66416/diff/2/
Changes: https://reviews.apache.org/r/66416/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin