You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/02/15 18:56:15 UTC
[Impala-ASF-CR] IMPALA-6515: [docs] HAproxy with sticky session requires the check option
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9293
Change subject: IMPALA-6515: [docs] HAproxy with sticky session requires the check option
......................................................................
IMPALA-6515: [docs] HAproxy with sticky session requires the check option
Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
---
M docs/topics/impala_proxy.xml
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9293/3
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alan Choi (Code Review)" <ge...@cloudera.org>.
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 20:29:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/206/
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 23:24:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alan Choi (Code Review)" <ge...@cloudera.org>.
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml@493
PS3, Line 493: an error when the Impalad server that Hue tries to connect is down.
> Did you get a chance to address this comment? If we don't know any caveats,
It's not clear why it is applicable to Hue.
From what I read, this will force HAProxy to check the host before making a connection by making a TCP connection. Does the benefit justify the slight delay? Or should the check be done at the user level (since most likely Impala is not down)?
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 20:59:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [docs] HAproxy with sticky session requires the check option
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [docs] HAproxy with sticky session requires the check option
......................................................................
Patch Set 3:
Different people from various field organizations have requested / suggested all sorts of combinations of HAProxy settings. There has never been a consistent set that worked the best for everyone. I suggest tagging in Alan Choi since he was the first one who verified the HAProxy instructions.
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Feb 2018 23:51:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Reviewed-on: http://gerrit.cloudera.org:8080/9293
Reviewed-by: Alan Choi <al...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_proxy.xml
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Alan Choi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 3:
(3 comments)
Just a couple of minor nits from me. But I would like for Alan or someone more familiar with the HAProxy stuff to be the one who actually gives the +2 from the technical side.
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@489
PS4, Line 489: attention
type="important" is the value we typically use for calling any extra attention to <note> elements.
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493
PS4, Line 493: that Hue tries to connect
Grammar: "to which Hue tries to connect".
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493
PS4, Line 493: the Impalad server
The way this is typically worded elsewhere is "the <cmdname>impalad</cmdname> daemon" to be clear about what has to be running.
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 19:34:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Alan Choi, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9293
to look at the new patch set (#5).
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
---
M docs/topics/impala_proxy.xml
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9293/5
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 23:12:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml@493
PS3, Line 493: an error when the Impalad server that Hue tries to connect is down.
> It's not clear why it is applicable to Hue.
So is it not Hue that requires the check option?
Then, can I just remove "Hue requires" and replace with "Add the check option at the end of each line"?
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 21:05:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Alan Choi, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9293
to look at the new patch set (#4).
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
---
M docs/topics/impala_proxy.xml
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9293/4
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9293/3/docs/topics/impala_proxy.xml@493
PS3, Line 493: an error when the Impalad server that Hue tries to connect is down.
> Are there any known caveats to using the 'check' option?
Did you get a chance to address this comment? If we don't know any caveats, that's okay with me. Just want to make sure.
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Mar 2018 19:43:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 23:29:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@489
PS4, Line 489: attention
> type="important" is the value we typically use for calling any extra attent
Done
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493
PS4, Line 493: the Impalad server
> The way this is typically worded elsewhere is "the <cmdname>impalad</cmdnam
Done
http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493
PS4, Line 493: that Hue tries to connect
> Grammar: "to which Hue tries to connect".
Done
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 20:54:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 )
Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8
Gerrit-Change-Number: 9293
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 00:36:04 +0000
Gerrit-HasComments: No