You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aaron Wood <aa...@verizon.com> on 2016/11/29 16:13:57 UTC
Re: Review Request 52645: Harden Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 4:13 p.m.)
Review request for mesos, James Peach, Michael Park, and Neil Conway.
Changes
-------
Changed the version of the macro (taken from 391cb680171d3889965b1ead43d3a326c913bc25)
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description (updated)
-------
Add hardened flags for Mesos.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
Diffs (updated)
-----
configure.ac 5380cbc
m4/ax_check_compile_flag.m4 PRE-CREATION
src/Makefile.am 85eda53
Diff: https://reviews.apache.org/r/52645/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood
Re: Review Request 52645: Harden Mesos
Posted by Aaron Wood <aa...@verizon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 8:51 p.m.)
Review request for mesos, James Peach, Michael Park, and Neil Conway.
Changes
-------
Don't warn when stack protection isn't used.
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description
-------
Add hardened flags for Mesos.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks on CentOS 6.
Diffs (updated)
-----
configure.ac 5380cbc
m4/ax_check_compile_flag.m4 PRE-CREATION
src/Makefile.am 7750ed7
Diff: https://reviews.apache.org/r/52645/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood
Re: Review Request 52645: Harden Mesos
Posted by Aaron Wood <aa...@verizon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 5:19 p.m.)
Review request for mesos, James Peach, Michael Park, and Neil Conway.
Changes
-------
Fixed newline issue in the macro.
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description
-------
Add hardened flags for Mesos.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks on CentOS 6.
Diffs (updated)
-----
configure.ac 5380cbc
m4/ax_check_compile_flag.m4 PRE-CREATION
src/Makefile.am 7750ed7
Diff: https://reviews.apache.org/r/52645/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood
Re: Review Request 52645: Harden Mesos
Posted by Aaron Wood <aa...@verizon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 4:21 p.m.)
Review request for mesos, James Peach, Michael Park, and Neil Conway.
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description
-------
Add hardened flags for Mesos.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks on CentOS 6.
Diffs (updated)
-----
configure.ac 5380cbc
m4/ax_check_compile_flag.m4 PRE-CREATION
src/Makefile.am 85eda53
Diff: https://reviews.apache.org/r/52645/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood
Re: Review Request 52645: Harden Mesos
Posted by Aaron Wood <aa...@verizon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 4:15 p.m.)
Review request for mesos, James Peach, Michael Park, and Neil Conway.
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description (updated)
-------
Add hardened flags for Mesos.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks on CentOS 6.
Diffs
-----
configure.ac 5380cbc
m4/ax_check_compile_flag.m4 PRE-CREATION
src/Makefile.am 85eda53
Diff: https://reviews.apache.org/r/52645/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood