You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2010/08/19 16:40:17 UTC

[jira] Created: (WICKET-3005) wicket should keep the url of a page that caused a runtime error

wicket should keep the url of a page that caused a runtime error
----------------------------------------------------------------

                 Key: WICKET-3005
                 URL: https://issues.apache.org/jira/browse/WICKET-3005
             Project: Wicket
          Issue Type: Bug
          Components: wicket
            Reporter: Peter Ertl
            Priority: Minor
         Attachments: control-redirect-on-errors.patch

In case wicket catches a runtime error it will redirect to an error page. In that case an url like

  http://127.0.0.1:8080//url/test?param=bad_value

will be replaced by something like

  http://127.0.0.1:8080/wicket/page?1

which is not very helpful (you won't be able to see that 'param' got a 'bad_value' in that case).

Also the user can not try to hit reload it the error is of temporary nature.

Additionally, after the session expires and the user hits reload on the url (and probably still hoping it get's better :-)

  http://127.0.0.1:8080/wicket/page

you will give you an http error '404 - page not found' as the error page url is not bookmarkable.

Keeping the source url and not doing a redirect would be better:

- reload in the browser will work
- expires pages will not break the URL

patch is included.






-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3005) wicket should keep the url of a page that caused a runtime error

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900883#action_12900883 ] 

Igor Vaynberg commented on WICKET-3005:
---------------------------------------

nice, this one has been driving me crazy lately, but not enough to fix yet :)

> wicket should keep the url of a page that caused a runtime error
> ----------------------------------------------------------------
>
>                 Key: WICKET-3005
>                 URL: https://issues.apache.org/jira/browse/WICKET-3005
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Priority: Minor
>             Fix For: 1.5-M2
>
>         Attachments: control-redirect-on-errors.patch
>
>
> In case wicket catches a runtime error it will redirect to an error page. In that case an url like
>   http://127.0.0.1:8080//url/test?param=bad_value
> will be replaced by something like
>   http://127.0.0.1:8080/wicket/page?1
> which is not very helpful (you won't be able to see that 'param' got a 'bad_value' in that case).
> Also the user can not try to hit reload it the error is of temporary nature.
> Additionally, after the session expires and the user hits reload on the url (and probably still hoping it get's better :-)
>   http://127.0.0.1:8080/wicket/page
> you will give you an http error '404 - page not found' as the error page url is not bookmarkable.
> Keeping the source url and not doing a redirect would be better:
> - reload in the browser will work
> - expires pages will not break the URL
> patch is included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3005) wicket should keep the url of a page that caused a runtime error

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-3005.
-----------------------------------

         Assignee: Igor Vaynberg
    Fix Version/s: 1.5-M2
       Resolution: Fixed

> wicket should keep the url of a page that caused a runtime error
> ----------------------------------------------------------------
>
>                 Key: WICKET-3005
>                 URL: https://issues.apache.org/jira/browse/WICKET-3005
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.5-M2
>
>         Attachments: control-redirect-on-errors.patch
>
>
> In case wicket catches a runtime error it will redirect to an error page. In that case an url like
>   http://127.0.0.1:8080//url/test?param=bad_value
> will be replaced by something like
>   http://127.0.0.1:8080/wicket/page?1
> which is not very helpful (you won't be able to see that 'param' got a 'bad_value' in that case).
> Also the user can not try to hit reload it the error is of temporary nature.
> Additionally, after the session expires and the user hits reload on the url (and probably still hoping it get's better :-)
>   http://127.0.0.1:8080/wicket/page
> you will give you an http error '404 - page not found' as the error page url is not bookmarkable.
> Keeping the source url and not doing a redirect would be better:
> - reload in the browser will work
> - expires pages will not break the URL
> patch is included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3005) wicket should keep the url of a page that caused a runtime error

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3005:
-------------------------------

    Attachment: control-redirect-on-errors.patch

> wicket should keep the url of a page that caused a runtime error
> ----------------------------------------------------------------
>
>                 Key: WICKET-3005
>                 URL: https://issues.apache.org/jira/browse/WICKET-3005
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Priority: Minor
>         Attachments: control-redirect-on-errors.patch
>
>
> In case wicket catches a runtime error it will redirect to an error page. In that case an url like
>   http://127.0.0.1:8080//url/test?param=bad_value
> will be replaced by something like
>   http://127.0.0.1:8080/wicket/page?1
> which is not very helpful (you won't be able to see that 'param' got a 'bad_value' in that case).
> Also the user can not try to hit reload it the error is of temporary nature.
> Additionally, after the session expires and the user hits reload on the url (and probably still hoping it get's better :-)
>   http://127.0.0.1:8080/wicket/page
> you will give you an http error '404 - page not found' as the error page url is not bookmarkable.
> Keeping the source url and not doing a redirect would be better:
> - reload in the browser will work
> - expires pages will not break the URL
> patch is included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3005) wicket should keep the url of a page that caused a runtime error

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900937#action_12900937 ] 

Hudson commented on WICKET-3005:
--------------------------------

Integrated in Apache Wicket 1.5.x #252 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/252/])
    

> wicket should keep the url of a page that caused a runtime error
> ----------------------------------------------------------------
>
>                 Key: WICKET-3005
>                 URL: https://issues.apache.org/jira/browse/WICKET-3005
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.5-M2
>
>         Attachments: control-redirect-on-errors.patch
>
>
> In case wicket catches a runtime error it will redirect to an error page. In that case an url like
>   http://127.0.0.1:8080//url/test?param=bad_value
> will be replaced by something like
>   http://127.0.0.1:8080/wicket/page?1
> which is not very helpful (you won't be able to see that 'param' got a 'bad_value' in that case).
> Also the user can not try to hit reload it the error is of temporary nature.
> Additionally, after the session expires and the user hits reload on the url (and probably still hoping it get's better :-)
>   http://127.0.0.1:8080/wicket/page
> you will give you an http error '404 - page not found' as the error page url is not bookmarkable.
> Keeping the source url and not doing a redirect would be better:
> - reload in the browser will work
> - expires pages will not break the URL
> patch is included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.