You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "style95 (via GitHub)" <gi...@apache.org> on 2023/05/19 23:40:31 UTC
[GitHub] [openwhisk] style95 opened a new pull request, #5415: Apply scalaFmt
style95 opened a new pull request, #5415:
URL: https://github.com/apache/openwhisk/pull/5415
<!--- Provide a concise summary of your changes in the Title -->
## Description
I am not quite sure when this regression is introduced and why our CI could not catch it in the first place, but anyway, codes are wrongly formatted.
This change just applies one from scalaFmt.
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 merged pull request #5415: Apply scalaFmt
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 merged PR #5415:
URL: https://github.com/apache/openwhisk/pull/5415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5415: Apply scalaFmt
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5415:
URL: https://github.com/apache/openwhisk/pull/5415#issuecomment-1555386674
## [Codecov](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5415](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (632ed73) into [master](https://app.codecov.io/gh/apache/openwhisk/commit/72bb2a1fc4783f29cb34d6ad1ffabf2b6676773b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (72bb2a1) will **decrease** coverage by `72.33%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 632ed73 differs from pull request most recent head cec7c3f. Consider uploading reports for the commit cec7c3f to get more accurate results
```diff
@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 76.83% 4.51% -72.33%
==========================================
Files 241 241
Lines 14630 14630
Branches 616 616
==========================================
- Hits 11241 660 -10581
- Misses 3389 13970 +10581
```
| [Impacted Files](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...enwhisk/core/entity/InstanceConcurrencyLimit.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0luc3RhbmNlQ29uY3VycmVuY3lMaW1pdC5zY2FsYQ==) | `0.00% <ø> (-75.00%)` | :arrow_down: |
| [.../openwhisk/core/entity/IntraConcurrencyLimit.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0ludHJhQ29uY3VycmVuY3lMaW1pdC5zY2FsYQ==) | `0.00% <ø> (-90.33%)` | :arrow_down: |
| [.../org/apache/openwhisk/core/controller/Limits.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9MaW1pdHMuc2NhbGE=) | `0.00% <0.00%> (-91.31%)` | :arrow_down: |
| [...che/openwhisk/core/loadBalancer/LeanBalancer.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbG9hZEJhbGFuY2VyL0xlYW5CYWxhbmNlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...la/org/apache/openwhisk/core/invoker/Invoker.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyLnNjYWxh) | `0.00% <0.00%> (-72.16%)` | :arrow_down: |
| [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://app.codecov.io/gh/apache/openwhisk/pull/5415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `0.00% <ø> (-71.54%)` | :arrow_down: |
... and [201 files with indirect coverage changes](https://app.codecov.io/gh/apache/openwhisk/pull/5415/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 commented on pull request #5415: Apply scalaFmt
Posted by "bdoyle0182 (via GitHub)" <gi...@apache.org>.
bdoyle0182 commented on PR #5415:
URL: https://github.com/apache/openwhisk/pull/5415#issuecomment-1555376797
This seems like it's from my two most recent PR's but I'm not sure why it wouldn't have been detected on build or if I had applied the wrong scalafmt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5415: Apply scalaFmt
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #5415:
URL: https://github.com/apache/openwhisk/pull/5415#issuecomment-1555378236
But I also think it should be caught by CI tests.
Our CI checks that.
https://github.com/apache/openwhisk/blob/master/tools/github/scan.sh#L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org