[GitHub] [activemq-artemis] tabish121 commented on a diff in pull request #4342: ARTEMIS-4132 AMQP Receiver default to ANYCAST when creating an address

["tabish121 (via GitHub)" <gi...@apache.org>]

tabish121 commented on code in PR #4342:
URL: https://github.com/apache/activemq-artemis/pull/4342#discussion_r1084289208


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java:
##########
@@ -1115,8 +1116,15 @@ public Consumer init(ProtonServerSenderContext senderContext) throws Exception {
             } else {
                // if not we look up the address
                AddressQueryResult addressQueryResult = null;
+
+               // Set this to the broker configured default for the address prior to the lookup so that
+               // an auto create will actually use the configured defaults.  The actual query result will
+               // contain the true answer on what routing type the address actually has though.
+               routingTypeToUse = sessionSPI.getDefaultRoutingType(addressToUse);
+               routingTypeToUse = routingTypeToUse == null ? ActiveMQDefaultConfiguration.getDefaultRoutingType() : routingTypeToUse;

Review Comment:
   Agree to disagree



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org