You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2018/05/23 12:16:00 UTC
[jira] [Commented] (QPID-8192) [Broker-J] Make bindingKey parameter
mandatory in exchange bind/unbind operations
[ https://issues.apache.org/jira/browse/QPID-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487149#comment-16487149 ]
Alex Rudyy commented on QPID-8192:
----------------------------------
Attached WIP patch. The patch makes bindingKey parameter mandatory in bind/unbind operations. Some changes in AMQP 0-9 protocol are required to handle the cases when bindingKey is null. AMQP 0-10 spec requires bindingKey on bind/unbind but AMQP 0-9.x specs do not specify the behaviour when bindingKey is null. I am going to modify AMQP 0-9.x path to close channel with an error on receiving null bindingKey on bind/unbind. I also going to add more 0-10 protocol tests for bind/unbind/bound as we do not have protocol tests for these operations
> [Broker-J] Make bindingKey parameter mandatory in exchange bind/unbind operations
> ---------------------------------------------------------------------------------
>
> Key: QPID-8192
> URL: https://issues.apache.org/jira/browse/QPID-8192
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, qpid-java-broker-7.0.1
> Reporter: Alex Rudyy
> Priority: Major
> Fix For: qpid-java-broker-7.1.0
>
> Attachments: 0001-QPID-8192-Broker-J-Make-bindingKey-parameter-mandato.patch
>
>
> Make bindingKey parameter mandatory in exchange bind/unbind operations but allow the value of the binding key to be the empty string. Optional bindingKey parameter causes confusions in understanding how bind/unbind operations works, as omitting bindingKey in unbind operation could be misinterpreted as bulk bindings deletion for the given destination. The unbind operation description text should be fixed as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org