You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/09 11:26:19 UTC
[GitHub] [camel-k] lburgazzoli opened a new issue, #3803: Improve error reporting in case of knative is required but not installed
lburgazzoli opened a new issue, #3803:
URL: https://github.com/apache/camel-k/issues/3803
When an integration that requires knative is created but knative is not installed, the camel-k operator must provide better insight about the missing pre-condition and should wait to deploy the integration till the pre-condition is satisfied.
As example, given the flowing integration:
```yaml
- from:
steps:
- to: log:info?showAll=true&multiLine=true
uri: knative:event/hello?name=test-broker
```
If you run it, then a standard deployment would be created and the integration pod would end in a `CrashLoopBackOff` state as the knative component lacks the information about how to properly run with a cryptic `java.lang.IllegalStateException: Cannot load Knative configuration from file or env variable`.
The resulting integration would look like:
```yaml
apiVersion: camel.apache.org/v1
kind: Integration
metadata:
name: test-integration
spec:
flows:
- from:
steps:
- to: log:info?showAll=true&multiLine=true
uri: knative:event/hello?name=test-broker
status:
conditions:
- firstTruthyTime: "2022-11-09T11:08:24Z"
lastTransitionTime: "2022-11-09T11:08:24Z"
lastUpdateTime: "2022-11-09T11:08:24Z"
message: default/camel-k
reason: IntegrationPlatformAvailable
status: "True"
type: IntegrationPlatformAvailable
- firstTruthyTime: "2022-11-09T11:09:24Z"
lastTransitionTime: "2022-11-09T11:09:24Z"
lastUpdateTime: "2022-11-09T11:09:24Z"
message: kit-cdloka391rhs73ejkffg
reason: IntegrationKitAvailable
status: "True"
type: IntegrationKitAvailable
- lastTransitionTime: "2022-11-09T11:09:24Z"
lastUpdateTime: "2022-11-09T11:09:24Z"
message: different controller strategy used (deployment)
reason: CronJobNotAvailableReason
status: "False"
type: CronJobAvailable
- firstTruthyTime: "2022-11-09T11:09:24Z"
lastTransitionTime: "2022-11-09T11:09:24Z"
lastUpdateTime: "2022-11-09T11:09:24Z"
message: deployment name is test-integration
reason: DeploymentAvailable
status: "True"
type: DeploymentAvailable
- firstTruthyTime: "2022-11-09T11:09:24Z"
lastTransitionTime: "2022-11-09T11:09:24Z"
lastUpdateTime: "2022-11-09T11:09:24Z"
message: test-integration(http/80) -> integration(http/8080)
reason: ServiceAvailable
status: "True"
type: ServiceAvailable
- lastTransitionTime: "2022-11-09T11:09:24Z"
lastUpdateTime: "2022-11-09T11:09:24Z"
message: no host or service defined
reason: IngressNotAvailable
status: "False"
type: ExposureAvailable
- firstTruthyTime: "2022-11-09T11:09:28Z"
lastTransitionTime: "2022-11-09T11:12:28Z"
lastUpdateTime: "2022-11-09T11:12:39Z"
message: back-off 2m40s restarting failed container=integration pod=test-integration-76b697c448-4bwp5_default(2910cf61-40e8-46d9-9d86-500529a5f94c)
reason: Error
status: "False"
type: Ready
phase: Error
platform: camel-k
profile: Kubernetes
```
The root problem can be derived by the fact that:
1. the profile is `Kubernetes`
2. there's no track of KnativeService in the conditions
3. the conditions reports that a standard deployment it's been created
But we should make it much more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1490461325
Two aspects I want to work on is:
- fail early, before the build starts, to not waste computing cycles and time, for early feedback
- set the failure reason in the integration status and condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1491009002
When the integration fails, is is described as
```
Last Transition Time: 2023-03-30T21:45:56Z
Last Update Time: 2023-03-30T21:45:56Z
Message: error during trait customization: integration cannot run, as knative is not installed in the cluser
Reason: InitializationFailed
Status: False
Type: Ready
...
Phase: Error
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #3803: Improve error reporting in case of knative is required but not installed
URL: https://github.com/apache/camel-k/issues/3803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1423411439
This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by GitBox <gi...@apache.org>.
christophd commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1308718079
I have had similar issues with YAKS. And I have added a `role` CLI command that is able to explicitly setup roles and permissions (user needs cluster admin privileges). This way the user can add Knative roles also after Camel K has been installed. Something like:
```
kamel roles --add knative
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1492266002
```
Last Transition Time: 2023-03-31T16:55:34Z
Last Update Time: 2023-03-31T16:55:34Z
Message: integration cannot run, as knative is not installed in the cluser
Reason: KnativeNotInstalled
Status: False
Type: KnativeAvailable
Last Transition Time: 2023-03-31T16:55:34Z
Last Update Time: 2023-03-31T16:55:34Z
Message: error during trait customization: integration cannot run, as knative is not installed in the cluser
Reason: InitializationFailed
Status: False
Type: Ready
```
Seems better to inform the user about the conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1309392941
> I have had similar issues with YAKS. And I have added a `role` CLI command that is able to explicitly setup roles and permissions (user needs cluster admin privileges). This way the user can add Knative roles also after Camel K has been installed. Something like:
>
In this particular example, knative was not even installed on purpose so I think the operator should not move forward deploying the integration as the minimum requirements to run the integration are not met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #3803: Improve error reporting in case of knative is required but not installed
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on issue #3803:
URL: https://github.com/apache/camel-k/issues/3803#issuecomment-1491350028
Maybe it would be nice to also have a condition about knative ?
```
-lastTransitionTime: "2022-11-09T11:09:24Z"
message: Knative is | is not available
reason: KnativeAvailable
status: "True|False"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org