You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Xiaodong DENG (JIRA)" <ji...@apache.org> on 2018/08/01 09:07:00 UTC
[jira] [Created] (AIRFLOW-2836) Minor improvement of
contrib.sensors.FileSensor
Xiaodong DENG created AIRFLOW-2836:
--------------------------------------
Summary: Minor improvement of contrib.sensors.FileSensor
Key: AIRFLOW-2836
URL: https://issues.apache.org/jira/browse/AIRFLOW-2836
Project: Apache Airflow
Issue Type: Improvement
Components: contrib
Reporter: Xiaodong DENG
Assignee: Xiaodong DENG
h4. *Background*
The default *fs_conn_id* in contrib.sensors.FileSensor is '_*fs_default2*_'. However, when we initiate the database (https://github.com/apache/incubator-airflow/blob/master/airflow/utils/db.py#L88), there isn't such an entry. It doesn't exist anywhere else.
h4. *Issue*
The purpose of _contrib.sensors.FileSensor_ is mainly for checking local file system (of course can also be used for NAS). Then the path ("/") from default connection 'fs_default' would suffice.
However, given the default value for *fs_conn_id* in contrib.sensors.FileSensor is "fs_default2" (a value doesn't exist), it will make the situation much more complex.
When users intend to check local file system only, they should be able to leave *fs_conn_id* default directly, instead of going setting up another connection separately.
h4. Proposal
Change default value for *fs_conn_id* in contrib.sensors.FileSensor from "fs_default2" to "fs_default" (actually in the related test, the *fs_conn_id* are all specified to be "fs_default").
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)