You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 19:11:59 UTC

[GitHub] [beam] lostluck opened a new pull request #12554: [BEAM-9615] Map user types to Schema reps.

lostluck opened a new pull request #12554:
URL: https://github.com/apache/beam/pull/12554


   * Add a schema.RegisterType method to preconvert user types to schema generated synthetic types, and be able to map them back to user types.
   * Add an schema option to indicate that the top level schema should be interpreted as a proto.
   * Add a field option to indicate whether a given int64 should actually be a go int.
     * Same for maps, arrays, and slice types.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/b
 eam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] pabloem commented on pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #12554:
URL: https://github.com/apache/beam/pull/12554#issuecomment-674298338


   thanks~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lostluck commented on pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #12554:
URL: https://github.com/apache/beam/pull/12554#issuecomment-674279973


   @lukecwik Thanks! I just noticed myself. I'm working on a fix.
   
   it's bewildering since initially the Precommit was failing, but I was able to get it to pass. Both the Precommit and the post commit should be using the same set of imports, so it's not clear how this can happen. Insert my usual rant about how I'll fix this with Go Modules after I'm done with this schema work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lostluck commented on a change in pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #12554:
URL: https://github.com/apache/beam/pull/12554#discussion_r470399845



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/schema_test.go
##########
@@ -161,18 +354,22 @@ func TestSchemaConversion(t *testing.T) {
 				if err != nil {
 					t.Fatalf("error ToType(%v) = %v", test.st, err)
 				}
-
-				if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
-					t.Errorf("diff (-want, +got): %v", d)
+				if !test.rt.AssignableTo(got) {
+					t.Errorf("%v not assignable to %v", test.rt, got)
+					if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
+						t.Errorf("diff (-want, +got): %v", d)
+					}
 				}
 			}
 			{
 				got, err := FromType(test.rt)
 				if err != nil {
 					t.Fatalf("error FromType(%v) = %v", test.rt, err)
 				}
-
-				if d := cmp.Diff(test.st, got); d != "" {
+				if d := cmp.Diff(test.st, got,
+					protocmp.Transform(),
+					protocmp.IgnoreFields(proto.MessageV2(&pipepb.Schema{}), "id", "options"),

Review comment:
       I'll try removing it before submitting. 
   I might have added this at an earlier iteration when the options also contained the fully qualified paths for comparison, which could vary from machine to machine. Those aren't being saved in the options anymore so it's fair for use to get rid of at this point I think....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lukecwik commented on pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12554:
URL: https://github.com/apache/beam/pull/12554#issuecomment-674284478


   Thanks for working on this so quickly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lostluck merged pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #12554:
URL: https://github.com/apache/beam/pull/12554


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lostluck commented on pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #12554:
URL: https://github.com/apache/beam/pull/12554#issuecomment-673092221


   R: @youngoli  
   
   I need to update the gogradle lock file for the protocmp package to get the tests to pass on jenkins but, this is reviewable.
   
   I've tried to comment around existing gaps and things, but do call them out when you see them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] youngoli commented on a change in pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
youngoli commented on a change in pull request #12554:
URL: https://github.com/apache/beam/pull/12554#discussion_r470392567



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/schema_test.go
##########
@@ -161,18 +354,22 @@ func TestSchemaConversion(t *testing.T) {
 				if err != nil {
 					t.Fatalf("error ToType(%v) = %v", test.st, err)
 				}
-
-				if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
-					t.Errorf("diff (-want, +got): %v", d)
+				if !test.rt.AssignableTo(got) {
+					t.Errorf("%v not assignable to %v", test.rt, got)
+					if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
+						t.Errorf("diff (-want, +got): %v", d)
+					}
 				}
 			}
 			{
 				got, err := FromType(test.rt)
 				if err != nil {
 					t.Fatalf("error FromType(%v) = %v", test.rt, err)
 				}
-
-				if d := cmp.Diff(test.st, got); d != "" {
+				if d := cmp.Diff(test.st, got,
+					protocmp.Transform(),
+					protocmp.IgnoreFields(proto.MessageV2(&pipepb.Schema{}), "id", "options"),

Review comment:
       I get why this is ignoring the "id" field for the proto, but why "options"? This test seems to already be testing options in the other direction (options are respected when converting from schemas to reflect types). I figure it would also want to test that options are included as expected when converting to schemas.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lostluck commented on a change in pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #12554:
URL: https://github.com/apache/beam/pull/12554#discussion_r470746162



##########
File path: sdks/go/pkg/beam/core/runtime/graphx/schema/schema_test.go
##########
@@ -161,18 +354,22 @@ func TestSchemaConversion(t *testing.T) {
 				if err != nil {
 					t.Fatalf("error ToType(%v) = %v", test.st, err)
 				}
-
-				if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
-					t.Errorf("diff (-want, +got): %v", d)
+				if !test.rt.AssignableTo(got) {
+					t.Errorf("%v not assignable to %v", test.rt, got)
+					if d := cmp.Diff(reflect.New(test.rt).Elem().Interface(), reflect.New(got).Elem().Interface()); d != "" {
+						t.Errorf("diff (-want, +got): %v", d)
+					}
 				}
 			}
 			{
 				got, err := FromType(test.rt)
 				if err != nil {
 					t.Fatalf("error FromType(%v) = %v", test.rt, err)
 				}
-
-				if d := cmp.Diff(test.st, got); d != "" {
+				if d := cmp.Diff(test.st, got,
+					protocmp.Transform(),
+					protocmp.IgnoreFields(proto.MessageV2(&pipepb.Schema{}), "id", "options"),

Review comment:
       As a note, it's good practice to approve but still request small changes when the other person is able to merge themselves. As committers we're already responsible to ensure the code is good for the project, but allowing folks to be unblocked is good for the community.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [beam] lukecwik commented on pull request #12554: [BEAM-9615] Map user types to Schema reps.

Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12554:
URL: https://github.com/apache/beam/pull/12554#issuecomment-674278113


   This PR seems to have broken :sdks:go:buildLinuxAmd64
   ```
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/buffer.go:11:2: cannot find package "google.golang.org/protobuf/encoding/prototext" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/encoding/prototext (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/encoding/prototext (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/encoding/prototext (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/buffer.go:12:2: cannot find package "google.golang.org/protobuf/encoding/protowire" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/encoding/protowire (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/encoding/protowire (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/encoding/protowire (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/deprecated.go:13:2: cannot find package "google.golang.org/protobuf/proto" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/proto (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/proto (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/proto (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/defaults.go:8:2: cannot find package "google.golang.org/protobuf/reflect/protoreflect" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/reflect/protoreflect (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/reflect/protoreflect (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/reflect/protoreflect (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/extensions.go:15:2: cannot find package "google.golang.org/protobuf/reflect/protoregistry" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/reflect/protoregistry (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/reflect/protoregistry (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/reflect/protoregistry (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/extensions.go:16:2: cannot find package "google.golang.org/protobuf/runtime/protoiface" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/runtime/protoiface (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/runtime/protoiface (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/runtime/protoiface (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto/buffer.go:13:2: cannot find package "google.golang.org/protobuf/runtime/protoimpl" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/runtime/protoimpl (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/runtime/protoimpl (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/runtime/protoimpl (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/protoc-gen-go/descriptor/descriptor.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/descriptorpb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/descriptorpb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/descriptorpb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/descriptorpb (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/ptypes/any/any.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/known/anypb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/known/anypb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/known/anypb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/known/anypb (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/ptypes/duration/duration.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/known/durationpb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/known/durationpb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/known/durationpb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/known/durationpb (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/ptypes/struct/struct.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/known/structpb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/known/structpb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/known/structpb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/known/structpb (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/ptypes/timestamp/timestamp.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/known/timestamppb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/known/timestamppb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/known/timestamppb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/known/timestamppb (from $GOPATH)
   .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/ptypes/wrappers/wrappers.pb.go:9:2: cannot find package "google.golang.org/protobuf/types/known/wrapperspb" in any of:
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/google.golang.org/protobuf/types/known/wrapperspb (vendor tree)
           /usr/local/google/home/lcwik/.gradle/go/binary/1.12/go/src/google.golang.org/protobuf/types/known/wrapperspb (from $GOROOT)
           /usr/local/google/home/lcwik/git/beam/sdks/go/.gogradle/project_gopath/src/google.golang.org/protobuf/types/known/wrapperspb (from $GOPATH)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org