You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by mm...@apache.org on 2020/01/17 08:30:49 UTC
[syncope] 02/03: fix parameter placeholders for log messages
This is an automated email from the ASF dual-hosted git repository.
mmoayyed pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/syncope.git
commit 648c6071a6b5f37509a21de3f429a554940da30b
Author: Misagh Moayyed <mm...@gmail.com>
AuthorDate: Thu Jan 16 22:20:51 2020 +0400
fix parameter placeholders for log messages
---
.../java/org/apache/syncope/client/console/status/ReconTaskPanel.java | 3 ++-
.../syncope/core/logic/init/ClassPathScanImplementationLookup.java | 2 +-
.../java/propagation/LDAPMembershipPropagationActions.java | 2 +-
.../src/main/java/org/apache/syncope/core/logic/SAML2IdPLogic.java | 2 +-
.../src/main/java/org/apache/syncope/core/logic/SAML2SPLogic.java | 2 +-
.../main/java/org/apache/syncope/core/logic/init/SAML2SPLoader.java | 2 +-
6 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/status/ReconTaskPanel.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/status/ReconTaskPanel.java
index 520555e..dfcd6a9 100644
--- a/client/idm/console/src/main/java/org/apache/syncope/client/console/status/ReconTaskPanel.java
+++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/status/ReconTaskPanel.java
@@ -185,7 +185,8 @@ public class ReconTaskPanel extends MultilevelPanel.SecondLevel {
SyncopeConsoleSession.get().info(getString(Constants.OPERATION_SUCCEEDED));
} catch (Exception e) {
- LOG.error("While attempting reconciliation on {}", reconQuery, form.getModelObject(), e);
+ LOG.error("While attempting reconciliation using query {} on {}",
+ reconQuery, form.getModelObject(), e);
SyncopeConsoleSession.get().error(resource + ": "
+ (StringUtils.isBlank(e.getMessage())
? e.getClass().getName()
diff --git a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java
index 655224f..a9ecdb0 100644
--- a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java
+++ b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java
@@ -116,7 +116,7 @@ public class ClassPathScanImplementationLookup implements ImplementationLookup {
scanner.addIncludeFilter(new AssignableTypeFilter(
ClassUtils.resolveClassName(typeInterface, ClassUtils.getDefaultClassLoader())));
} catch (IllegalArgumentException e) {
- LOG.error("Could not find class {}, ignoring...", e);
+ LOG.error("Could not find class, ignoring...", e);
}
});
diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/LDAPMembershipPropagationActions.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/LDAPMembershipPropagationActions.java
index 854340d..1a4e5c4 100644
--- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/LDAPMembershipPropagationActions.java
+++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/LDAPMembershipPropagationActions.java
@@ -128,7 +128,7 @@ public class LDAPMembershipPropagationActions implements PropagationActions {
forEach(value -> groups.add(String.valueOf(value)));
}
}
- LOG.debug("Add ldapGroups to attributes: {}" + groups);
+ LOG.debug("Add ldapGroups to attributes: {}", groups);
attributes.add(AttributeBuilder.build(getGroupMembershipAttrName(), groups));
task.setAttributes(attributes);
diff --git a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2IdPLogic.java b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2IdPLogic.java
index 31c3a12..f988610 100644
--- a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2IdPLogic.java
+++ b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2IdPLogic.java
@@ -77,7 +77,7 @@ public class SAML2IdPLogic extends AbstractSAML2Logic<SAML2IdPTO> {
try {
idpEntity = cache.put(idp);
} catch (Exception e) {
- LOG.error("Could not build SAML 2.0 IdP with key ", idp.getEntityID(), e);
+ LOG.error("Could not build SAML 2.0 IdP with key {}", idp.getEntityID(), e);
}
}
diff --git a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2SPLogic.java b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2SPLogic.java
index de8eb2f..cb73614 100644
--- a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2SPLogic.java
+++ b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/SAML2SPLogic.java
@@ -242,7 +242,7 @@ public class SAML2SPLogic extends AbstractSAML2Logic<EntityTO> {
try {
idp = cache.put(saml2IdP);
} catch (Exception e) {
- LOG.error("Could not build SAML 2.0 IdP with key ", entityID, e);
+ LOG.error("Could not build SAML 2.0 IdP with key {}", entityID, e);
SyncopeClientException sce = SyncopeClientException.build(ClientExceptionType.Unknown);
sce.getElements().add(e.getMessage());
throw sce;
diff --git a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/init/SAML2SPLoader.java b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/init/SAML2SPLoader.java
index cbbf37c..a8d4997 100644
--- a/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/init/SAML2SPLoader.java
+++ b/ext/saml2sp/logic/src/main/java/org/apache/syncope/core/logic/init/SAML2SPLoader.java
@@ -147,7 +147,7 @@ public class SAML2SPLoader implements SyncopeCoreLoader {
try {
cache.put(idp);
} catch (Exception e) {
- LOG.error("Could not cache the SAML 2.0 IdP with key ", idp.getEntityID(), e);
+ LOG.error("Could not cache the SAML 2.0 IdP with key {}", idp.getEntityID(), e);
}
});
return null;