[GitHub] [pulsar] mattisonchao opened a new pull request, #17216: [fix][test] Fix `PersistentDispatcherFailoverConsumerTest#testAddRemoveConsumer` wrong logic.

[GitBox <gi...@apache.org>]

mattisonchao opened a new pull request, #17216:
URL: https://github.com/apache/pulsar/pull/17216

   ### Motivation
   
   From issue #14540, I found this test has some logic problems.
   
   Look at step 7 in the test. If we remove the last consumer, the active consumer will change. The logic you can see at `AbstractDispatcherSingleActiveConsumer#pickAndScheduleActiveConsumer` method.
   
   At this time, We will get three notifications. The current new active consumer is `consumer1`, So If we remove `consumer0`. We will not get a notification. 
   
   I'm unsure if we can fix the #14540, but the original flaky relative logic is changed.
   
   ### Modifications
   
   - Fix the wrong test logic to fit the `pickAndScheduleActiveConsumer`.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   (Please explain why)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao merged pull request #17216: [fix][test] Fix `PersistentDispatcherFailoverConsumerTest#testAddRemoveConsumer` wrong logic.

[GitBox <gi...@apache.org>]

mattisonchao merged PR #17216:
URL: https://github.com/apache/pulsar/pull/17216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org