[GitHub] [curator] tisonkun commented on a change in pull request #409: CURATOR-633: Fix backward compatibility in tests

[GitBox <gi...@apache.org>]

tisonkun commented on a change in pull request #409:
URL: https://github.com/apache/curator/pull/409#discussion_r815245304



##########
File path: curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -91,7 +92,10 @@ public void stateChanged(CuratorFramework client, ConnectionState newState)
     }
 
     @Test
-    public void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws Exception {
+    void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws Exception {

Review comment:
       I think it's not logically incompatible.
   
   1. If you remove `@Test` above, this test doesn't actually run in any condition.
   2. The original error report on JIRA looks because https://github.com/apache/zookeeper/pull/799 wasn't include in zk 3.5. And the usage of `queueEvent` here can be emulated by bringing back bridges of `queueEvent` like https://github.com/apache/curator/pull/344/ removed - it's not a logically incompatible.
        




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org