You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/09/16 06:47:24 UTC

[GitHub] [servicecomb-java-chassis] qubo11 commented on issue #2581: InvocationTimeout优化

qubo11 commented on issue #2581:
URL: https://github.com/apache/servicecomb-java-chassis/issues/2581#issuecomment-920624483


   不是这个意思哈。
   ![image](https://user-images.githubusercontent.com/4074496/133562972-d50e352a-73c5-4391-aae8-dba3273672e2.png)
   和异步没有关系,同步也是这样。
   
   我的意思是,invocation.onBusinessMethodStart();发布了InvocationBusinessMethodStartEvent事件,然后InvocationTimeoutBootListener类中对这个事件处理了。invocation.onBusinessMethodFinish();发布了InvocationBusinessMethodFinishEvent事件,但是InvocationTimeoutBootListener类中处理的是invocation.onBusinessFinish();这个方法发布的事件:
   ![image](https://user-images.githubusercontent.com/4074496/133563306-b68a8972-ea77-4ec1-967d-5d9ae707289a.png)
   我看代码的时候就比较疑惑,为啥InvocationTimeoutBootListener不是处理InvocationBusinessMethodFinishEvent事件而是InvocationBusinessFinishEvent事件。
   
   我和宝哥说了下,他说可以优化一下。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org