You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2017/11/16 07:40:08 UTC
hbase git commit: HBASE-18964 Deprecated RowProcessor and
Region#processRowsWithLocks() methods that take RowProcessor as an argument
Repository: hbase
Updated Branches:
refs/heads/master b35e18ccc -> 570d786ac
HBASE-18964 Deprecated RowProcessor and Region#processRowsWithLocks() methods that take RowProcessor as an argument
Signed-off-by: Michael Stack <st...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/570d786a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/570d786a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/570d786a
Branch: refs/heads/master
Commit: 570d786ac44a92d5b04cdf0b5ae6a707db486b03
Parents: b35e18c
Author: Umesh Agashe <ua...@cloudera.com>
Authored: Tue Nov 14 14:22:49 2017 -0800
Committer: Michael Stack <st...@apache.org>
Committed: Wed Nov 15 23:40:00 2017 -0800
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/regionserver/HRegion.java | 2 +-
.../java/org/apache/hadoop/hbase/regionserver/Region.java | 9 +++++++++
.../org/apache/hadoop/hbase/regionserver/RowProcessor.java | 8 ++++++--
3 files changed, 16 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/570d786a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
index 3a3cb03..14d6a9d 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
@@ -3853,7 +3853,7 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi
nonceKey.getNonceGroup(), nonceKey.getNonce(), batchOp.getOrigLogSeqNum());
}
- // STEP 6. Complete mvcc for all but last writeEntry (for replay case)
+ // Complete mvcc for all but last writeEntry (for replay case)
if (it.hasNext() && writeEntry != null) {
mvcc.complete(writeEntry);
writeEntry = null;
http://git-wip-us.apache.org/repos/asf/hbase/blob/570d786a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
index 2d66d52..75f02a3 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java
@@ -409,7 +409,10 @@ public interface Region extends ConfigurationObserver {
* Performs atomic multiple reads and writes on a given row.
*
* @param processor The object defines the reads and writes to a row.
+ * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. For customization, use
+ * Coprocessors instead.
*/
+ @Deprecated
void processRowsWithLocks(RowProcessor<?,?> processor) throws IOException;
/**
@@ -418,9 +421,12 @@ public interface Region extends ConfigurationObserver {
* @param processor The object defines the reads and writes to a row.
* @param nonceGroup Optional nonce group of the operation (client Id)
* @param nonce Optional nonce of the operation (unique random id to ensure "more idempotence")
+ * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. For customization, use
+ * Coprocessors instead.
*/
// TODO Should not be exposing with params nonceGroup, nonce. Change when doing the jira for
// Changing processRowsWithLocks and RowProcessor
+ @Deprecated
void processRowsWithLocks(RowProcessor<?,?> processor, long nonceGroup, long nonce)
throws IOException;
@@ -432,9 +438,12 @@ public interface Region extends ConfigurationObserver {
* Use a negative number to switch off the time bound
* @param nonceGroup Optional nonce group of the operation (client Id)
* @param nonce Optional nonce of the operation (unique random id to ensure "more idempotence")
+ * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. For customization, use
+ * Coprocessors instead.
*/
// TODO Should not be exposing with params nonceGroup, nonce. Change when doing the jira for
// Changing processRowsWithLocks and RowProcessor
+ @Deprecated
void processRowsWithLocks(RowProcessor<?,?> processor, long timeout, long nonceGroup, long nonce)
throws IOException;
http://git-wip-us.apache.org/repos/asf/hbase/blob/570d786a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
index 625d9a6..c79571c 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java
@@ -39,11 +39,15 @@ import com.google.protobuf.Message;
* This class performs scans and generates mutations and WAL edits.
* The locks and MVCC will be handled by HRegion.
*
- * The RowProcessor user code could have data that needs to be
- * sent across for proper initialization at the server side. The generic type
+ * The RowProcessor user code could have data that needs to be
+ * sent across for proper initialization at the server side. The generic type
* parameter S is the type of the request data sent to the server.
* The generic type parameter T is the return type of RowProcessor.getResult().
+ *
+ * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. For customization, use
+ * Coprocessors instead.
*/
+@Deprecated
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)
@InterfaceStability.Evolving
public interface RowProcessor<S extends Message, T extends Message> {