You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Steve Eynon (JIRA)" <ji...@apache.org> on 2011/09/03 10:42:09 UTC
[jira] [Updated] (TAP5-1628) Have Submit documentation explicitly
state when the disabled attribute is evaluated
[ https://issues.apache.org/jira/browse/TAP5-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Eynon updated TAP5-1628:
------------------------------
Description:
The "disabled" attribute for a Submit button is currently loosely documented as :
" ... Further, a disabled field ignores any value in the request when the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
was:
The "disabled" attribute for a Submit button is currently loosely
documented as :
" ... Further, a disabled field ignores any value in the request when
the form is submitted."
http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
I would like it to be more explicit, along the lines of:
" ... Further, if bound, the disabled attribute is re-evaluated upon
form submission and the "selected" event is only fired should it
evaluate to 'false'."
For this stumped us in work today for a good half hour - it was
because we weren't @Persist'ing our disabled attribute. Our expression
was t:disabled="!myObject" and of course 'myObject' because null /
false on form submission. As our submit button was enabled and the
form submitted, we saw no reason for the event not to fire.
> Have Submit documentation explicitly state when the disabled attribute is evaluated
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1628
> URL: https://issues.apache.org/jira/browse/TAP5-1628
> Project: Tapestry 5
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 5.3
> Reporter: Steve Eynon
> Priority: Trivial
> Labels: submit
>
> The "disabled" attribute for a Submit button is currently loosely documented as :
> " ... Further, a disabled field ignores any value in the request when the form is submitted."
> http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/corelib/components/Submit.html
> I would like it to be more explicit, along the lines of:
> " ... Further, if bound, the disabled attribute is re-evaluated upon form submission and the "selected" event is only fired should it evaluate to 'false'."
> For this stumped us in work today for a good half hour - it was because we weren't @Persist'ing our disabled attribute. Our expression was t:disabled="!myObject" and of course 'myObject' because null / false on form submission. As our submit button was enabled and the form submitted, we saw no reason for the event not to fire.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira