You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2007/05/25 04:09:58 UTC
Re: svn commit: r541512 - in /maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/plan: BuildPlan.java BuildPlanIfc.java
Was this intentional? Doesn't seem like a naming convention
consistent with the rest of the project.
On 25/05/2007, at 12:06 PM, jdcasey@apache.org wrote:
> Author: jdcasey
> Date: Thu May 24 19:06:24 2007
> New Revision: 541512
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=541512
> Log:
> Preparing to refactor the build-plan stuff to make it a little less
> complex and more usable...and to re-activate late-binding of
> plugins when necessary.
>
> Added:
> maven/components/trunk/maven-core/src/main/java/org/apache/
> maven/lifecycle/plan/BuildPlanIfc.java
> - copied, changed from r541352, maven/components/trunk/maven-
> core/src/main/java/org/apache/maven/lifecycle/plan/BuildPlan.java
> Removed:
> maven/components/trunk/maven-core/src/main/java/org/apache/
> maven/lifecycle/plan/BuildPlan.java
>
> Copied: maven/components/trunk/maven-core/src/main/java/org/apache/
> maven/lifecycle/plan/BuildPlanIfc.java (from r541352, maven/
> components/trunk/maven-core/src/main/java/org/apache/maven/
> lifecycle/plan/BuildPlan.java)
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/
> src/main/java/org/apache/maven/lifecycle/plan/BuildPlanIfc.java?
> view=diff&rev=541512&p1=maven/components/trunk/maven-core/src/main/
> java/org/apache/maven/lifecycle/plan/
> BuildPlan.java&r1=541352&p2=maven/components/trunk/maven-core/src/
> main/java/org/apache/maven/lifecycle/plan/BuildPlanIfc.java&r2=541512
> ======================================================================
> ========
> --- maven/components/trunk/maven-core/src/main/java/org/apache/
> maven/lifecycle/plan/BuildPlan.java (original)
> +++ maven/components/trunk/maven-core/src/main/java/org/apache/
> maven/lifecycle/plan/BuildPlanIfc.java Thu May 24 19:06:24 2007
> @@ -7,7 +7,7 @@
>
> import java.util.List;
>
> -public interface BuildPlan
> +public interface BuildPlanIfc
> extends ModifiablePlanElement
> {
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r541512 - in /maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/plan: BuildPlan.java BuildPlanIfc.java
Posted by Brett Porter <br...@apache.org>.
Coolio. Thanks for clearing it up for me :)
On 25/05/2007, at 12:14 PM, John Casey wrote:
> I'm just getting it out of the way, so I can refactor in peace. SVN
> doesn't like it when you move something to another file, then try
> to replace the old filename with a new file without committing
> first. I'm almost done with a new BuildPlan implementation, and I'm
> not quite ready to break everything else to put it in.
>
> In other words, this interface will be going away soon, so don't
> worry.
>
> I'm trying to fix it0013, fwiw.
>
> -john
>
>
> On May 24, 2007, at 10:09 PM, Brett Porter wrote:
>
>> Was this intentional? Doesn't seem like a naming convention
>> consistent with the rest of the project.
>>
>> On 25/05/2007, at 12:06 PM, jdcasey@apache.org wrote:
>>
>>> Author: jdcasey
>>> Date: Thu May 24 19:06:24 2007
>>> New Revision: 541512
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=541512
>>> Log:
>>> Preparing to refactor the build-plan stuff to make it a little
>>> less complex and more usable...and to re-activate late-binding of
>>> plugins when necessary.
>>>
>>> Added:
>>> maven/components/trunk/maven-core/src/main/java/org/apache/
>>> maven/lifecycle/plan/BuildPlanIfc.java
>>> - copied, changed from r541352, maven/components/trunk/
>>> maven-core/src/main/java/org/apache/maven/lifecycle/plan/
>>> BuildPlan.java
>>> Removed:
>>> maven/components/trunk/maven-core/src/main/java/org/apache/
>>> maven/lifecycle/plan/BuildPlan.java
>>>
>>> Copied: maven/components/trunk/maven-core/src/main/java/org/
>>> apache/maven/lifecycle/plan/BuildPlanIfc.java (from r541352,
>>> maven/components/trunk/maven-core/src/main/java/org/apache/maven/
>>> lifecycle/plan/BuildPlan.java)
>>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-
>>> core/src/main/java/org/apache/maven/lifecycle/plan/
>>> BuildPlanIfc.java?view=diff&rev=541512&p1=maven/components/trunk/
>>> maven-core/src/main/java/org/apache/maven/lifecycle/plan/
>>> BuildPlan.java&r1=541352&p2=maven/components/trunk/maven-core/src/
>>> main/java/org/apache/maven/lifecycle/plan/
>>> BuildPlanIfc.java&r2=541512
>>> ====================================================================
>>> ==========
>>> --- maven/components/trunk/maven-core/src/main/java/org/apache/
>>> maven/lifecycle/plan/BuildPlan.java (original)
>>> +++ maven/components/trunk/maven-core/src/main/java/org/apache/
>>> maven/lifecycle/plan/BuildPlanIfc.java Thu May 24 19:06:24 2007
>>> @@ -7,7 +7,7 @@
>>>
>>> import java.util.List;
>>>
>>> -public interface BuildPlan
>>> +public interface BuildPlanIfc
>>> extends ModifiablePlanElement
>>> {
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> ---
> John Casey
> Committer and PMC Member, Apache Maven
> mail: jdcasey at commonjava dot org
> blog: http://www.ejlife.net/blogs/john
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r541512 - in /maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/plan: BuildPlan.java BuildPlanIfc.java
Posted by John Casey <jd...@commonjava.org>.
I'm just getting it out of the way, so I can refactor in peace. SVN
doesn't like it when you move something to another file, then try to
replace the old filename with a new file without committing first.
I'm almost done with a new BuildPlan implementation, and I'm not
quite ready to break everything else to put it in.
In other words, this interface will be going away soon, so don't worry.
I'm trying to fix it0013, fwiw.
-john
On May 24, 2007, at 10:09 PM, Brett Porter wrote:
> Was this intentional? Doesn't seem like a naming convention
> consistent with the rest of the project.
>
> On 25/05/2007, at 12:06 PM, jdcasey@apache.org wrote:
>
>> Author: jdcasey
>> Date: Thu May 24 19:06:24 2007
>> New Revision: 541512
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=541512
>> Log:
>> Preparing to refactor the build-plan stuff to make it a little
>> less complex and more usable...and to re-activate late-binding of
>> plugins when necessary.
>>
>> Added:
>> maven/components/trunk/maven-core/src/main/java/org/apache/
>> maven/lifecycle/plan/BuildPlanIfc.java
>> - copied, changed from r541352, maven/components/trunk/maven-
>> core/src/main/java/org/apache/maven/lifecycle/plan/BuildPlan.java
>> Removed:
>> maven/components/trunk/maven-core/src/main/java/org/apache/
>> maven/lifecycle/plan/BuildPlan.java
>>
>> Copied: maven/components/trunk/maven-core/src/main/java/org/apache/
>> maven/lifecycle/plan/BuildPlanIfc.java (from r541352, maven/
>> components/trunk/maven-core/src/main/java/org/apache/maven/
>> lifecycle/plan/BuildPlan.java)
>> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-
>> core/src/main/java/org/apache/maven/lifecycle/plan/
>> BuildPlanIfc.java?view=diff&rev=541512&p1=maven/components/trunk/
>> maven-core/src/main/java/org/apache/maven/lifecycle/plan/
>> BuildPlan.java&r1=541352&p2=maven/components/trunk/maven-core/src/
>> main/java/org/apache/maven/lifecycle/plan/BuildPlanIfc.java&r2=541512
>> =====================================================================
>> =========
>> --- maven/components/trunk/maven-core/src/main/java/org/apache/
>> maven/lifecycle/plan/BuildPlan.java (original)
>> +++ maven/components/trunk/maven-core/src/main/java/org/apache/
>> maven/lifecycle/plan/BuildPlanIfc.java Thu May 24 19:06:24 2007
>> @@ -7,7 +7,7 @@
>>
>> import java.util.List;
>>
>> -public interface BuildPlan
>> +public interface BuildPlanIfc
>> extends ModifiablePlanElement
>> {
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---
John Casey
Committer and PMC Member, Apache Maven
mail: jdcasey at commonjava dot org
blog: http://www.ejlife.net/blogs/john