[jira] [Commented] (NIFI-5013) NiFi Standard Processors should build a test jar to reduce duplication

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412089#comment-16412089 ] 

ASF GitHub Bot commented on NIFI-5013:
--------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/nifi/pull/2580

    NIFI-5013 create test jar for standard processors

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/nifi standard-proc-test-jar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2580
    
----
commit 1c05db64c1b85d3313a60816f1578c790b4d3509
Author: Otto Fowler <ot...@...>
Date:   2018-03-23T21:13:45Z

    create test jar for standard processors
    
    remove unnec TestServer instances

----


> NiFi Standard Processors should build a test jar to reduce duplication
> ----------------------------------------------------------------------
>
>                 Key: NIFI-5013
>                 URL: https://issues.apache.org/jira/browse/NIFI-5013
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>
> There are some classes, notably TestServer, which are in the nifi standard processors jar which could be used by other processors, either in the project ( already 2 or 3 copies ) or in 3rd party processor/controller projects.
> [link Apache Maven|https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html] details how to handle this case in two ways.
>  
>  #  create a test-jar from the project
>  # create a new module to hold shared testing code and scope:test include it
> While #2 is the preferred way, nifi should support #1 in the interim, until some discussion on the location and structure of the test module(s) and the classes that should be moved to them happens.  The scope there will be quite a bit larger.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)