You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by "glcj (via GitHub)" <gi...@apache.org> on 2025/04/06 22:41:08 UTC

[I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

glcj opened a new issue, #2050:
URL: https://github.com/apache/plc4x/issues/2050

   ### What happened?
   
   When requesting a very long structure, the optimizer correctly partitions the requests but ignores the last response packet.
   
     Request:          readrequest.addTagAddress("TEST", "%DB45:0:USINT[896]"); //(02) 
   
   [s7315.zip](https://github.com/user-attachments/files/19623853/s7315.zip)
   
   ### Version
   
   v0.13.0-SNAPSHOT
   
   ### Programming Languages
   
   - [ ] plc4c
   - [ ] plc4go
   - [x] plc4j
   - [ ] plc4net
   - [ ] plc4py
   
   ### Protocols
   
   - [ ] AB-Ethernet
   - [ ] ADS /AMS
   - [ ] BACnet/IP
   - [ ] C-Bus
   - [ ] CANopen
   - [ ] EtherNet/IP
   - [ ] Firmata
   - [ ] IEC-69870
   - [ ] KNXnet/IP
   - [ ] Modbus
   - [ ] OPC-UA
   - [ ] Profinet
   - [x] S7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "glcj (via GitHub)" <gi...@apache.org>.
glcj commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2781744566

   List of bytes returned by the optimizer encapsulated in an optimizer object.
   
   ![Image](https://github.com/user-attachments/assets/4a310e13-8193-44d9-9601-9f8ef052d4bd)
   
   Without optimization it returns a PlcList
   
   ![Image](https://github.com/user-attachments/assets/8ee108f0-ad27-4630-abbb-05d8d07b9b2a)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2785103012

   But the value it returns is a PlcValue. Yes it's not a PlcList, but PlcList itself is not an API type. A PlcList implements the same interface as any PlcValue. And as the modifyable list in the optimizer extends the PlcValueAdapter this should too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2782050428

   It's this using the default optimizer or the new block based one? And does it affect the s7 or s7-light driver?
   
   Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
   ________________________________
   From: César José García León ***@***.***>
   Sent: Monday, April 7, 2025 2:10:18 AM
   To: apache/plc4x ***@***.***>
   Cc: Subscribed ***@***.***>
   Subject: Re: [apache/plc4x] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed. (Issue #2050)
   
   
   List of bytes returned by the optimizer encapsulated in an optimizer object.
   
   imagen.png (view on web)<https://github.com/user-attachments/assets/4a310e13-8193-44d9-9601-9f8ef052d4bd>
   
   Without optimization it returns a PlcList
   
   imagen.png (view on web)<https://github.com/user-attachments/assets/8ee108f0-ad27-4630-abbb-05d8d07b9b2a>
   
   —
   Reply to this email directly, view it on GitHub<https://github.com/apache/plc4x/issues/2050#issuecomment-2781744566>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAE66YMC3HEVFTZ4KMOJA5L2YG66VAVCNFSM6AAAAAB2SGBNVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRG42DINJWGY>.
   You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
   
   [glcj]glcj left a comment (apache/plc4x#2050)<https://github.com/apache/plc4x/issues/2050#issuecomment-2781744566>
   
   List of bytes returned by the optimizer encapsulated in an optimizer object.
   
   imagen.png (view on web)<https://github.com/user-attachments/assets/4a310e13-8193-44d9-9601-9f8ef052d4bd>
   
   Without optimization it returns a PlcList
   
   imagen.png (view on web)<https://github.com/user-attachments/assets/8ee108f0-ad27-4630-abbb-05d8d07b9b2a>
   
   —
   Reply to this email directly, view it on GitHub<https://github.com/apache/plc4x/issues/2050#issuecomment-2781744566>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAE66YMC3HEVFTZ4KMOJA5L2YG66VAVCNFSM6AAAAAB2SGBNVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBRG42DINJWGY>.
   You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2786007007

   So I think the fully API compliant way to do it, would be to check if it's PlcValue type and if this is a list and then to call the getList() method. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2782178403

   As I don't seem to quite understand your response: So the default s7 optimizer (not the new version I built) is generally doing, what it should, but it's returning an inner class (The modifyable list) and this is missing the content of the last packet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "glcj (via GitHub)" <gi...@apache.org>.
glcj commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2782109672

   Hi,
   
   The default optimizer does its job, but the request returns an inner class. I have two response types for the same request.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "glcj (via GitHub)" <gi...@apache.org>.
glcj commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2789990941

   Hello,
   
   I'm going to close this bug as it's more a matter of interpretation.
   
   Ultimately, my problem is consistently solved by reading the data directly from the byte array with "%DB45:0:BYTE[896]" or "%DB45:0:RAW_BYTE_ARRAY[896]", returning a "PlcRawByteArray".
   
   If variable-length data types are requested, the PlcValue interpretation is not straightforward, so it must be evaluated at the application level.
   
   Thanks,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "glcj (via GitHub)" <gi...@apache.org>.
glcj closed issue #2050: [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.
URL: https://github.com/apache/plc4x/issues/2050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug]: Response failure with S7315-2PN/DP. The last packet is not processed.

Posted by "glcj (via GitHub)" <gi...@apache.org>.
glcj commented on issue #2050:
URL: https://github.com/apache/plc4x/issues/2050#issuecomment-2784574645

   Hello,
   After continuing the processing, the Optimizer performs its work correctly.
   The problem is in the returned object.
   
   For a request that is smaller than the maximum PDU, my program expects a "PlcList," which works without problems.
   
   When the Optimizer comes in, that is, when the returned data is larger than the size of a PDU, the returned type does not correspond to a "PlcList," but rather "S7Optimizer.PlcListModifiable."
   
   I think the returned "PlcValue" should be the expected type ("PlcList") and not a type not included in the API/SPI.
   
   This difference mainly affects me with isolated objects (OSGi).
   
   I'm modifying the application to use "PlcValue."


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org