You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/10 14:42:15 UTC
[GitHub] [maven-parent] kwin opened a new pull request, #90: [MPOM-354] leverage new report plugin
kwin opened a new pull request, #90:
URL: https://github.com/apache/maven-parent/pull/90
use javadoc from plugin documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1020273864
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
Created https://issues.apache.org/jira/browse/MPOM-358 and removed from this PR.
##########
pom.xml:
##########
@@ -1212,21 +1213,8 @@ under the License.
<reportSets>
<reportSet>
<reports>
+ <!-- only generate index by default, all other reports only active with profile "reporting" -->
<report>index</report>
- <report>summary</report>
- <report>dependency-info</report>
- <report>modules</report>
- <report>team</report>
- <report>scm</report>
- <report>issue-management</report>
- <report>mailing-lists</report>
- <report>dependency-management</report>
- <report>dependencies</report>
- <report>dependency-convergence</report>
- <report>ci-management</report>
- <report>plugin-management</report>
- <report>plugins</report>
- <report>distribution-management</report>
Review Comment:
Created https://issues.apache.org/jira/browse/MPOM-358 and removed from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019378271
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
Separate profile only to be consistent how we do it now.
It is, what I mention from time to time - I think that we have to many reports, and we introduce one simple site build and one with full reports with profile - but consensus is difficult to achieve.
Sometime during release special profile can be forgotten....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019431694
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
Ok, so what about moving all reports (incl. `maven-plugin-report-plugin` and `maven-project-info-reports-plugin`) to the profile `reporting` and always activate that profile during (in addition to `apache-release`) in `release:perform` (https://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#releaseProfiles)? Then only the manually maintained pages are built during a regular `site` execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1020227694
##########
pom.xml:
##########
@@ -1080,6 +1080,7 @@ under the License.
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
+ <releaseProfiles>apache-release,reporting</releaseProfiles>
Review Comment:
Should be for next PR - it is out of scope for me
##########
pom.xml:
##########
@@ -1212,21 +1213,8 @@ under the License.
<reportSets>
<reportSet>
<reports>
+ <!-- only generate index by default, all other reports only active with profile "reporting" -->
<report>index</report>
- <report>summary</report>
- <report>dependency-info</report>
- <report>modules</report>
- <report>team</report>
- <report>scm</report>
- <report>issue-management</report>
- <report>mailing-lists</report>
- <report>dependency-management</report>
- <report>dependencies</report>
- <report>dependency-convergence</report>
- <report>ci-management</report>
- <report>plugin-management</report>
- <report>plugins</report>
- <report>distribution-management</report>
Review Comment:
Should be for next PR - it is out of scope for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019286693
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
we already have such report in maven-parent,
it is in reporting profile ... so maybe also maven-plugin-report-plugin should be in reporting profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019470524
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
Done in https://github.com/apache/maven-parent/pull/90/commits/82990e3a4c6c0f9896a0a32dd66d58ef0ee7b670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019300267
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
why the separate profile? What is the site lifecycle supposed to generate without that profile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #90:
URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019431694
##########
maven-plugins/pom.xml:
##########
@@ -145,9 +148,21 @@ under the License.
<reporting>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <reportSets>
+ <reportSet>
+ <id>default</id>
+ <reports>
+ <report>javadoc</report>
+ </reports>
+ </reportSet>
+ </reportSets>
+ </plugin>
Review Comment:
Ok, so what about moving all reports (incl. `maven-plugin-report-plugin` and `maven-project-info-reports-plugin`) to the profile `reporting` and always activate that profile (in addition to `apache-release`) in `release:perform` (https://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html#releaseProfiles)? Then only the manually maintained pages are built during a regular `site` execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-parent] kwin merged pull request #90: [MPOM-354] leverage new report plugin
Posted by GitBox <gi...@apache.org>.
kwin merged PR #90:
URL: https://github.com/apache/maven-parent/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org