You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/02/04 18:21:14 UTC
[GitHub] [maven-doxia-converter] kwin commented on a diff in pull request #38: DOXIATOOLS-75 improved directory input support
kwin commented on code in PR #38:
URL: https://github.com/apache/maven-doxia-converter/pull/38#discussion_r1096569785
##########
src/main/java/org/apache/maven/doxia/cli/CLIManager.java:
##########
@@ -159,8 +164,12 @@ private static String getSupportedFormatAndEncoding()
private static String getSupportedFormat()
{
- return "\nSupported Formats:\n from: " + join( DefaultConverter.SUPPORTED_FROM_FORMAT, ", " )
- + " or autodetect" + "\n to: " + join( DefaultConverter.SUPPORTED_TO_FORMAT, ", " )
+ String fromFormats = EnumSet.allOf( DefaultConverter.ParserFormat.class ).stream()
+ .map( f -> f.toString().toLowerCase() ).collect( Collectors.joining( ", " ) );
+ String toFormats = EnumSet.allOf( DefaultConverter.SinkFormat.class ).stream()
+ .map( f -> f.toString().toLowerCase() ).collect( Collectors.joining( ", " ) );
+ return "\nSupported Formats:\n from: " + fromFormats
+ + " or " + AUTO_FORMAT + "\n to: " + toFormats
+ "\n";
Review Comment:
Done in https://github.com/apache/maven-doxia-converter/pull/38/commits/2b480deb54709437a7062846324d74bf3e415c37 (although not really related to this PR as `\n` was used everywhere else before)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org