You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David Forsythe <df...@gmail.com> on 2015/12/26 23:08:50 UTC
Review Request 41730: Re-enable HTTPConnectionTest.ClosingRequest on
FreeBSD.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41730/
-----------------------------------------------------------
Review request for mesos and Ian Downes.
Bugs: MESOS-4252
https://issues.apache.org/jira/browse/MESOS-4252
Repository: mesos
Description
-------
Re-enable HTTPConnectionTest.ClosingRequest on FreeBSD.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
Diff: https://reviews.apache.org/r/41730/diff/
Testing
-------
gmake check
Thanks,
David Forsythe
Re: Review Request 41730: Re-enable HTTPConnectionTest.ClosingRequest
on FreeBSD.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41730/#review111909
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41596, 41730]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 26, 2015, 10:08 p.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41730/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 10:08 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-4252
> https://issues.apache.org/jira/browse/MESOS-4252
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Re-enable HTTPConnectionTest.ClosingRequest on FreeBSD.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
>
> Diff: https://reviews.apache.org/r/41730/diff/
>
>
> Testing
> -------
>
> gmake check
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 41730: Re-enable HTTPConnectionTest.ClosingRequest
on FreeBSD.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41730/#review113312
-----------------------------------------------------------
Ship it!
No need to re-submit.
3rdparty/libprocess/src/tests/http_tests.cpp (line 910)
<https://reviews.apache.org/r/41730/#comment173851>
I'll fix on commit but please keep two newlines between tests.
- Ian Downes
On Dec. 26, 2015, 2:08 p.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41730/
> -----------------------------------------------------------
>
> (Updated Dec. 26, 2015, 2:08 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-4252
> https://issues.apache.org/jira/browse/MESOS-4252
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Re-enable HTTPConnectionTest.ClosingRequest on FreeBSD.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp 19261502be220aaa40add7ce30a9b2b65d1d9fdc
>
> Diff: https://reviews.apache.org/r/41730/diff/
>
>
> Testing
> -------
>
> gmake check
>
>
> Thanks,
>
> David Forsythe
>
>