You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/18 06:48:55 UTC

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".

jingshanglu commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r471951187



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
     ;
 
 columnNames
-    : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+    : LP_ columnName (COMMA_ columnName)* RP_

Review comment:
       @dongzl Maybe it's not appropriate,because `columnNames` is used by `createIndex` in DDLStatement.g4, and actually `columnNameWithSort` is right. url:https://docs.microsoft.com/zh-cn/sql/t-sql/statements/create-index-transact-sql?view=sql-server-ver15




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org