You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pdfbox.apache.org by GitBox <gi...@apache.org> on 2022/04/18 10:07:32 UTC

[GitHub] [pdfbox] THausherr commented on pull request #107: potential memory leaks and small performance improvements

THausherr commented on PR #107:
URL: https://github.com/apache/pdfbox/pull/107#issuecomment-1101283438

   > > This pull request **introduces 1 alert** when merging [d3c1021](https://github.com/apache/pdfbox/commit/d3c10211f5202cb1baa98cb4b365ff6b6a5334b0) into [9db582c](https://github.com/apache/pdfbox/commit/9db582c98f00619aae7d8db5708de3ad68fdeb7f) - [view on LGTM.com](https://lgtm.com/projects/g/apache/pdfbox/rev/pr-f2db0250a63562390f2dce579cf3c21fe6c83cf1)
   > > **new alerts:**
   > > 
   > > * 1 for Boxed variable is never null
   > 
   > Hi! The prevSum variable is 'int', the 'current.intValue()' is Number. So, result can be int or Integer. Check next row, please. We add this value to list. For list it always be Integer. I reduced redurant convertion, IMHO.
   
   IMHO both are the same. Many fixes because of LGTM and Sonar are just for reduce the complaints in order to be able to see some real problems 😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org