You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/17 20:27:34 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #2985:
ARTEMIS-2587 auto-create dead-letter resources
jbertram opened a new pull request #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985
This is a reimplementation of the IndividualDeadLetterQueueStrategy
from 5.x in a way that makes sense with the Artemis addressing model.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2985:
ARTEMIS-2587 auto-create dead-letter resources
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-589076816
@jbertram perhaps instead of creating a specialized option for DLQ and a specialized option for Expiry, we could make it generic, so the same feature would apply to both?
instead of auto-create-DLQ.. we could call it auto-create-output-resources ? something on that line.. dunno?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #2985:
ARTEMIS-2587 auto-create dead-letter resources
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-587152927
Nice. Is it possible to do same for expiry?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2985: ARTEMIS-2587
& ARTEMIS-2624 auto-create dead-letter & expiry resources
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #2985: ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-589211499
FYI - I just pushed a commit to deal with the expiry resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2985: ARTEMIS-2587
auto-create dead-letter resources
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-587211163
@michaelandrepearce, yes the same can be done for expiry. However, that would be on different Jira & PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2985: ARTEMIS-2587 &
ARTEMIS-2624 auto-create dead-letter & expiry resources
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2985: ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
URL: https://github.com/apache/activemq-artemis/pull/2985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2985:
ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2985: ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-589268644
@jbertram looks good.. there's a test failure on the PR though. seems legit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#2985: ARTEMIS-2587 auto-create dead-letter resources
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-587152927
Nice. Is it possible to do same for expiry? As in Artemis we have dlq and expiry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #2985:
ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #2985: ARTEMIS-2587 & ARTEMIS-2624 auto-create dead-letter & expiry resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-589268799
it's probably due to the config changes performed. the test probably needs to be adapted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #2985: ARTEMIS-2587
auto-create dead-letter resources
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #2985: ARTEMIS-2587 auto-create dead-letter resources
URL: https://github.com/apache/activemq-artemis/pull/2985#issuecomment-587147524
Most of the changes here are for the new address-settings, tests, docs, etc. The actual substantive changes to support this feature is a 10-line function - `org.apache.activemq.artemis.core.server.impl.QueueImpl#createDeadLetterResources`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services