You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Andreas Kohn <an...@gmail.com> on 2013/11/11 11:43:58 UTC
Review Request 15409: Support getting only specific messages by id in
JsonDbOpensocialService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15409/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1948
https://issues.apache.org/jira/browse/SHINDIG-1948
Repository: shindig
Description
-------
Filter messages against the provided message id list.
Diffs
-----
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1540645
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1540645
Diff: https://reviews.apache.org/r/15409/diff/
Testing
-------
Unit test in patch.
Thanks,
Andreas Kohn
Re: Review Request 15409: Support getting only specific messages by id in
JsonDbOpensocialService
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15409/#review28734
-----------------------------------------------------------
Ship it!
Committed revision 1541040. Please close this review.
- Stanton Sievers
On Nov. 11, 2013, 10:45 a.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15409/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 10:45 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1948
> https://issues.apache.org/jira/browse/SHINDIG-1948
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Filter messages against the provided message id list.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1540645
> trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1540645
>
> Diff: https://reviews.apache.org/r/15409/diff/
>
>
> Testing
> -------
>
> Unit test in patch.
>
>
> Thanks,
>
> Andreas Kohn
>
>
Re: Review Request 15409: Support getting only specific messages by id in
JsonDbOpensocialService
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15409/#review28649
-----------------------------------------------------------
Ship it!
Given the wording in the spec, I think this patch is good. The spec doesn't explicitly define when only a Message would be returned, only that it can be returned as opposed to a Collection<Message>. It is, as you point out in the JIRA, a little vague.
- Stanton Sievers
On Nov. 11, 2013, 10:45 a.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15409/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 10:45 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1948
> https://issues.apache.org/jira/browse/SHINDIG-1948
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Filter messages against the provided message id list.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1540645
> trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1540645
>
> Diff: https://reviews.apache.org/r/15409/diff/
>
>
> Testing
> -------
>
> Unit test in patch.
>
>
> Thanks,
>
> Andreas Kohn
>
>
Re: Review Request 15409: Support getting only specific messages by id in
JsonDbOpensocialService
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15409/#review28705
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On Nov. 11, 2013, 10:45 a.m., Andreas Kohn wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15409/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 10:45 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1948
> https://issues.apache.org/jira/browse/SHINDIG-1948
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Filter messages against the provided message id list.
>
>
> Diffs
> -----
>
> trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1540645
> trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1540645
>
> Diff: https://reviews.apache.org/r/15409/diff/
>
>
> Testing
> -------
>
> Unit test in patch.
>
>
> Thanks,
>
> Andreas Kohn
>
>
Re: Review Request 15409: Support getting only specific messages by id in
JsonDbOpensocialService
Posted by Andreas Kohn <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15409/
-----------------------------------------------------------
(Updated Nov. 11, 2013, 10:45 a.m.)
Review request for shindig.
Changes
-------
Fix whitespace.
Bugs: SHINDIG-1948
https://issues.apache.org/jira/browse/SHINDIG-1948
Repository: shindig
Description
-------
Filter messages against the provided message id list.
Diffs (updated)
-----
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1540645
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1540645
Diff: https://reviews.apache.org/r/15409/diff/
Testing
-------
Unit test in patch.
Thanks,
Andreas Kohn