You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/01/03 21:16:15 UTC
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 9:16 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Changes
-------
Redo this patch on top of r/54821
Summary (updated)
-----------------
Made mesos-docker-execute understand cgroups_enable_cfs.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description (updated)
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/#review164146
-----------------------------------------------------------
src/docker/docker.cpp (line 786)
<https://reviews.apache.org/r/51052/#comment235733>
Fixing this typo right now.
- Zhitao Li
On Feb. 3, 2017, 6:56 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51052/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 6:56 p.m.)
>
>
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-6134
> https://issues.apache.org/jira/browse/MESOS-6134
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixed cpu quota for command executor (which runs outside
> of the docker container) by ensuing --cpu-quota flag to docker
> run.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
> src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
> src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
> src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
> src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
> src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
>
> Diff: https://reviews.apache.org/r/51052/diff/
>
>
> Testing
> -------
>
> I am now able to make docker containers launched through mesos-execute have a cpu quota.
>
> Also making sure `make check` still works on mac os for the linux only flag.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/#review164307
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 5, 2017, 11:09 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51052/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2017, 11:09 p.m.)
>
>
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-6134
> https://issues.apache.org/jira/browse/MESOS-6134
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixed cpu quota for command executor (which runs outside
> of the docker container) by ensuing --cpu-quota flag to docker
> run.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
> src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
> src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
> src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
> src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
> src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
>
> Diff: https://reviews.apache.org/r/51052/diff/
>
>
> Testing
> -------
>
> I am now able to make docker containers launched through mesos-execute have a cpu quota.
>
> Also making sure `make check` still works on mac os for the linux only flag.
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 11:09 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 11:01 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 7:34 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Changes
-------
Fix typo.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 6:56 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Changes
-------
Rebase with master.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Re: Review Request 51052: Made mesos-docker-execute understand
cgroups_enable_cfs.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 7:39 p.m.)
Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
Changes
-------
rebase with dependent patch change.
Bugs: MESOS-6134
https://issues.apache.org/jira/browse/MESOS-6134
Repository: mesos
Description
-------
This fixed cpu quota for command executor (which runs outside
of the docker container) by ensuing --cpu-quota flag to docker
run.
Diffs (updated)
-----
src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47
src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6
src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6
src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
Diff: https://reviews.apache.org/r/51052/diff/
Testing
-------
I am now able to make docker containers launched through mesos-execute have a cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li