You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/07 21:37:00 UTC

[jira] [Commented] (KAFKA-7893) Refactor ConsumerBounceTest.scala

    [ https://issues.apache.org/jira/browse/KAFKA-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763099#comment-16763099 ] 

ASF GitHub Bot commented on KAFKA-7893:
---------------------------------------

stanislavkozlovski commented on pull request #6238: KAFKA-7893 Refactor ConsumerBounceTest to reuse functionality from BaseConsumerTest
URL: https://github.com/apache/kafka/pull/6238
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor ConsumerBounceTest.scala
> ---------------------------------
>
>                 Key: KAFKA-7893
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7893
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Stanislav Kozlovski
>            Assignee: Stanislav Kozlovski
>            Priority: Minor
>
> The [ConsumerBounceTest|https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala] has logic to create consumers and ensure that they are in the same consumer group. There is code that already does this in `BaseConsumerTest` and `PlaintextConsumerTest` - it would be better if we could make `ConsumerBounceTest` reuse that functionality.
> As part of [https://github.com/apache/kafka/pull/6163,] it is worth investigating if we could assert the newly-introduced test cases there with unit tests as opposed to integration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)