You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/19 07:48:10 UTC

[GitHub] [netbeans-mavenutils-nbm-maven-plugin] JaroslavTulach commented on pull request #17: remove pack200 from nbm-maven-plugin

JaroslavTulach commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-781898969


   Cannot the functionality stay there and just yield a decent build failure on JDK14+? If you want to compile on JDK14+ (which may also be desirable goal) then I suggest to modify the compiler section like this:
   ```
           <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-compiler-plugin</artifactId>
               <version>3.8.1</version>
               <dependencies>
                   <dependency>
                       <groupId>org.frgaal</groupId>
                       <artifactId>compiler-maven-plugin</artifactId>
                       <version>15.0.0</version>
                   </dependency>
               </dependencies>
               <configuration>
                   <compilerId>frgaal</compilerId>
                   <source>1.8</source>
                   <target>1.8</target>
               </configuration>
           </plugin>
   ```
   That way the code is going to compile on any JDK8+ and the `pack200` functionality is going to work on any JDK <14.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists