You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/22 20:03:21 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #7020: Make the json node field in GenericRecord public
vzhikserg opened a new pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020
### Motivation
It is possible to [reach](https://github.com/apache/pulsar/blob/f90fab280c931d457877de87c12b7d59074f6f6c/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/GenericAvroRecord.java#L64) the field containing the native Avro record, but GenericJsonRecord hides the JsonNode field. It makes sense to even it out and make the JsonNode publicly available.
### Modifications
The public access modifier was added to the getter for JsonNode and the GenericJsonRecord class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633102270
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg removed a comment on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg removed a comment on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633102270
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg removed a comment on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg removed a comment on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633115183
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633194343
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633145823
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #7020: Make the json node field in GenericRecord public
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #7020:
URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633115183
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org