You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/03/14 23:08:13 UTC
[GitHub] [arrow-datafusion] Weijun-H opened a new pull request, #5606: create table default to null
Weijun-H opened a new pull request, #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5575
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on a diff in pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1138667303
##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -170,13 +170,6 @@ impl TableProvider for MemTable {
// Create a physical plan from the logical plan.
let plan = state.create_physical_plan(input).await?;
- // Check that the schema of the plan matches the schema of this table.
Review Comment:
You should not delete this piece of code. Since you deleted it, you will not capture the errors if you change
https://github.com/apache/arrow-datafusion/blob/23814092bdd80533a5a673a5076d21125c8ef1e3/datafusion/core/tests/sqllogictests/test_files/ddl.slt#L442-L444
into
```
# Should create an empty table
statement ok
CREATE OR REPLACE TABLE table_without_values(field1 BIGINT, field2 BIGINT);
```
which is the default behavior of PostgreSQL. Defensive coding might bring bugs to light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on a diff in pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1138682158
##########
datafusion/sql/src/statement.rs:
##########
@@ -127,42 +129,66 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&& table_properties.is_empty()
&& with_options.is_empty() =>
{
- let plan = self.query_to_plan(*query, planner_context)?;
- let input_schema = plan.schema();
-
- let plan = if !columns.is_empty() {
- let schema = self.build_schema(columns)?.to_dfschema_ref()?;
- if schema.fields().len() != input_schema.fields().len() {
- return Err(DataFusionError::Plan(format!(
+ match query {
+ Some(query) => {
+ let plan = self.query_to_plan(*query, planner_context)?;
+ let input_schema = plan.schema();
+
+ let plan = if !columns.is_empty() {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
Review Comment:
The problem of the `NOT NULL` default is still here since you did not change the `self.build_schema(columns)`.
This should be the default behaviour:
```rust
pub fn build_schema(&self, columns: Vec<SQLColumnDef>) -> Result<Schema> {
let mut fields = Vec::with_capacity(columns.len());
for column in columns {
let data_type = self.convert_simple_data_type(&column.data_type)?;
let prevent_null = column
.options
.iter()
.any(|x| x.option == ColumnOption::NotNull);
fields.push(Field::new(
normalize_ident(column.name, self.options.enable_ident_normalization),
data_type,
!prevent_null,
));
}
Ok(Schema::new(fields))
}
```
then, it would help if you changed the `sqllogictests`, for example, from
```
describe table_with_normalization
----
field1 Int64 NO
field2 Int64 NO
```
to
```
describe table_with_normalization
----
field1 Int64 YES
field2 Int64 YES
```
In this way, you can give the same defaults with PostgreSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5606: create table default to null
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1140426082
##########
datafusion/sql/src/planner.rs:
##########
@@ -130,14 +130,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
for column in columns {
let data_type = self.convert_simple_data_type(&column.data_type)?;
- let allow_null = column
+ let prevent_null = column
Review Comment:
nit: I would name the variable nullable/not_nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#issuecomment-1470496132
I will review it carefully tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5606: create table default to null
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1143996616
##########
datafusion/sql/src/statement.rs:
##########
@@ -181,10 +207,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
definition: sql,
}))
}
- Statement::CreateTable { .. } => Err(DataFusionError::NotImplemented(
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5606: create table default to null
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1140430185
##########
datafusion/core/tests/sqllogictests/src/engines/datafusion/mod.rs:
##########
@@ -80,29 +77,8 @@ async fn run_query(ctx: &SessionContext, sql: impl Into<String>) -> Result<DFOut
// Check if the sql is `insert`
if let Ok(mut statements) = DFParser::parse_sql(&sql) {
let statement0 = statements.pop_front().expect("at least one SQL statement");
- if let Statement::Statement(statement) = statement0 {
- let statement = *statement;
- match statement {
- SQLStatement::CreateTable {
- query,
- constraints,
- table_properties,
- with_options,
- name,
- columns,
- if_not_exists,
- or_replace,
- ..
- } if query.is_none()
- && constraints.is_empty()
- && table_properties.is_empty()
- && with_options.is_empty() =>
- {
- return create_table(ctx, name, columns, if_not_exists, or_replace)
- .await
- }
- _ => {}
- };
+ if let Statement::Statement(_) = statement0 {
+ {}
Review Comment:
nit: it might be good in such cases leave your own comments in the PR saying why this change was done. I noticed people here doing such way and that looks cool :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#issuecomment-1479025429
Such a good PR, thanks for the effort @Weijun-H 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5606: create table default to null
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on a diff in pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1138717193
##########
datafusion/sql/src/statement.rs:
##########
@@ -127,42 +129,66 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&& table_properties.is_empty()
&& with_options.is_empty() =>
{
- let plan = self.query_to_plan(*query, planner_context)?;
- let input_schema = plan.schema();
-
- let plan = if !columns.is_empty() {
- let schema = self.build_schema(columns)?.to_dfschema_ref()?;
- if schema.fields().len() != input_schema.fields().len() {
- return Err(DataFusionError::Plan(format!(
+ match query {
+ Some(query) => {
+ let plan = self.query_to_plan(*query, planner_context)?;
+ let input_schema = plan.schema();
+
+ let plan = if !columns.is_empty() {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
+ if schema.fields().len() != input_schema.fields().len() {
+ return Err(DataFusionError::Plan(format!(
"Mismatch: {} columns specified, but result has {} columns",
schema.fields().len(),
input_schema.fields().len()
)));
+ }
+ let input_fields = input_schema.fields();
+ let project_exprs = schema
+ .fields()
+ .iter()
+ .zip(input_fields)
+ .map(|(field, input_field)| {
+ cast(
+ col(input_field.name()),
+ field.data_type().clone(),
+ )
+ .alias(field.name())
+ })
+ .collect::<Vec<_>>();
+ LogicalPlanBuilder::from(plan.clone())
+ .project(project_exprs)?
+ .build()?
+ } else {
+ plan
+ };
+
+ Ok(LogicalPlan::CreateMemoryTable(CreateMemoryTable {
+ name: self.object_name_to_table_reference(name)?,
+ input: Arc::new(plan),
+ if_not_exists,
+ or_replace,
+ }))
}
- let input_fields = input_schema.fields();
- let project_exprs = schema
- .fields()
- .iter()
- .zip(input_fields)
- .map(|(field, input_field)| {
- cast(col(input_field.name()), field.data_type().clone())
- .alias(field.name())
- })
- .collect::<Vec<_>>();
- LogicalPlanBuilder::from(plan.clone())
- .project(project_exprs)?
- .build()?
- } else {
- plan
- };
-
- Ok(LogicalPlan::CreateMemoryTable(CreateMemoryTable {
- name: self.object_name_to_table_reference(name)?,
- input: Arc::new(plan),
- if_not_exists,
- or_replace,
- }))
+
+ None => {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
+ let plan = EmptyRelation {
+ produce_one_row: false,
+ schema,
+ };
+ let plan = LogicalPlan::EmptyRelation(plan);
Review Comment:
Cool idea 👍🏻
##########
datafusion/sql/src/statement.rs:
##########
@@ -127,42 +129,66 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&& table_properties.is_empty()
&& with_options.is_empty() =>
{
- let plan = self.query_to_plan(*query, planner_context)?;
- let input_schema = plan.schema();
-
- let plan = if !columns.is_empty() {
- let schema = self.build_schema(columns)?.to_dfschema_ref()?;
- if schema.fields().len() != input_schema.fields().len() {
- return Err(DataFusionError::Plan(format!(
+ match query {
+ Some(query) => {
+ let plan = self.query_to_plan(*query, planner_context)?;
+ let input_schema = plan.schema();
+
+ let plan = if !columns.is_empty() {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
+ if schema.fields().len() != input_schema.fields().len() {
+ return Err(DataFusionError::Plan(format!(
"Mismatch: {} columns specified, but result has {} columns",
schema.fields().len(),
input_schema.fields().len()
)));
+ }
+ let input_fields = input_schema.fields();
+ let project_exprs = schema
+ .fields()
+ .iter()
+ .zip(input_fields)
+ .map(|(field, input_field)| {
+ cast(
+ col(input_field.name()),
+ field.data_type().clone(),
+ )
+ .alias(field.name())
+ })
+ .collect::<Vec<_>>();
+ LogicalPlanBuilder::from(plan.clone())
+ .project(project_exprs)?
+ .build()?
+ } else {
+ plan
+ };
+
+ Ok(LogicalPlan::CreateMemoryTable(CreateMemoryTable {
+ name: self.object_name_to_table_reference(name)?,
+ input: Arc::new(plan),
+ if_not_exists,
+ or_replace,
+ }))
}
- let input_fields = input_schema.fields();
- let project_exprs = schema
- .fields()
- .iter()
- .zip(input_fields)
- .map(|(field, input_field)| {
- cast(col(input_field.name()), field.data_type().clone())
- .alias(field.name())
- })
- .collect::<Vec<_>>();
- LogicalPlanBuilder::from(plan.clone())
- .project(project_exprs)?
- .build()?
- } else {
- plan
- };
-
- Ok(LogicalPlan::CreateMemoryTable(CreateMemoryTable {
- name: self.object_name_to_table_reference(name)?,
- input: Arc::new(plan),
- if_not_exists,
- or_replace,
- }))
+
+ None => {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
Review Comment:
The problem of the `NOT NULL` default is still here since you did not change the `self.build_schema(columns)`.
This should be the default behaviour:
```rust
pub fn build_schema(&self, columns: Vec<SQLColumnDef>) -> Result<Schema> {
let mut fields = Vec::with_capacity(columns.len());
for column in columns {
let data_type = self.convert_simple_data_type(&column.data_type)?;
let prevent_null = column
.options
.iter()
.any(|x| x.option == ColumnOption::NotNull);
fields.push(Field::new(
normalize_ident(column.name, self.options.enable_ident_normalization),
data_type,
!prevent_null,
));
}
Ok(Schema::new(fields))
}
```
then, it would help if you changed the `sqllogictests`, for example, from
```
describe table_with_normalization
----
field1 Int64 NO
field2 Int64 NO
```
to
```
describe table_with_normalization
----
field1 Int64 YES
field2 Int64 YES
```
In this way, you can give the same defaults with PostgreSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on a diff in pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1138667303
##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -170,13 +170,6 @@ impl TableProvider for MemTable {
// Create a physical plan from the logical plan.
let plan = state.create_physical_plan(input).await?;
- // Check that the schema of the plan matches the schema of this table.
Review Comment:
You should not delete this piece of code. Since you deleted it, you will not capture the errors if you change
https://github.com/apache/arrow-datafusion/blob/23814092bdd80533a5a673a5076d21125c8ef1e3/datafusion/core/tests/sqllogictests/test_files/ddl.slt#L442-L444
into
```
# Should create an empty table
statement ok
CREATE OR REPLACE TABLE table_without_values(field1 BIGINT, field2 BIGINT);
```
which is the default behavior of PostgreSQL.
##########
datafusion/core/tests/sqllogictests/test_files/ddl.slt:
##########
@@ -553,3 +553,15 @@ set datafusion.sql_parser.parse_float_as_decimal = false;
statement ok
set datafusion.sql_parser.enable_ident_normalization = true;
+
+
+statement ok
+create table foo(x int);
+
+statement ok
+insert into foo values (null);
+
+query I
+select * from foo;
+----
+NULL
Review Comment:
Cool 👍🏻
##########
datafusion/sql/src/statement.rs:
##########
@@ -127,42 +129,66 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&& table_properties.is_empty()
&& with_options.is_empty() =>
{
- let plan = self.query_to_plan(*query, planner_context)?;
- let input_schema = plan.schema();
-
- let plan = if !columns.is_empty() {
- let schema = self.build_schema(columns)?.to_dfschema_ref()?;
- if schema.fields().len() != input_schema.fields().len() {
- return Err(DataFusionError::Plan(format!(
+ match query {
+ Some(query) => {
+ let plan = self.query_to_plan(*query, planner_context)?;
+ let input_schema = plan.schema();
+
+ let plan = if !columns.is_empty() {
+ let schema = self.build_schema(columns)?.to_dfschema_ref()?;
Review Comment:
The problem of the `NOT NULL` default is still here since you did not change the `self.build_schema(columns)`.
This should be the default behaviour:
```rust
pub fn build_schema(&self, columns: Vec<SQLColumnDef>) -> Result<Schema> {
let mut fields = Vec::with_capacity(columns.len());
for column in columns {
let data_type = self.convert_simple_data_type(&column.data_type)?;
let prevent_null = column
.options
.iter()
.any(|x| x.option == ColumnOption::NotNull);
fields.push(Field::new(
normalize_ident(column.name, self.options.enable_ident_normalization),
data_type,
!prevent_null,
));
}
Ok(Schema::new(fields))
}
```
then, it would help if you changed the `sqllogictests`, for example, from
```
describe table_with_normalization
----
field1 Int64 NO
field2 Int64 NO
```
to
```
describe table_with_normalization
----
field1 Int64 YES
field2 Int64 YES
```
In this way, you can give the same defaults with PostgreSQL.
##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -170,13 +170,6 @@ impl TableProvider for MemTable {
// Create a physical plan from the logical plan.
let plan = state.create_physical_plan(input).await?;
- // Check that the schema of the plan matches the schema of this table.
- if !plan.schema().eq(&self.schema) {
- return Err(DataFusionError::Plan(
Review Comment:
`DataFusionError::Plan` can be converted to `DataFusionError::Internal` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5606: create table default to null
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1137257666
##########
datafusion/sql/src/statement.rs:
##########
@@ -127,42 +129,66 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
&& table_properties.is_empty()
&& with_options.is_empty() =>
{
- let plan = self.query_to_plan(*query, planner_context)?;
- let input_schema = plan.schema();
-
- let plan = if !columns.is_empty() {
- let schema = self.build_schema(columns)?.to_dfschema_ref()?;
- if schema.fields().len() != input_schema.fields().len() {
- return Err(DataFusionError::Plan(format!(
+ match query {
+ Some(query) => {
Review Comment:
looks like this code will handle traditoinal create table no just CTAS, do you think we can remove ```
Statement::CreateTable { .. } => Err(DataFusionError::NotImplemented(
"Only `CREATE TABLE table_name AS SELECT ...` statement is supported"
.to_string(),
)),
```
condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5606: create table default to null
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#discussion_r1140426082
##########
datafusion/sql/src/planner.rs:
##########
@@ -130,14 +130,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
for column in columns {
let data_type = self.convert_simple_data_type(&column.data_type)?;
- let allow_null = column
+ let prevent_null = column
Review Comment:
nit: Maybe the variable nullable/not_nullable would be better to read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5606: create table default to null
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#issuecomment-1478529916
Marking as draft as this PR has feedback pending. Let us know if you need help finishing this one up @Weijun-H
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on pull request #5606: create table default to null
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #5606:
URL: https://github.com/apache/arrow-datafusion/pull/5606#issuecomment-1472254765
LGTM! Thanks for the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org