You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:03:04 UTC

[GitHub] [daffodil] jadams-tresys commented on pull request #694: Check for RepType when getting element length

jadams-tresys commented on pull request #694:
URL: https://github.com/apache/daffodil/pull/694#issuecomment-1044665050


   > What changed since this was last reviewed? Unfortunately GitHub doesn't have a way to show that.
   > 
   > Also there were some discussions about potentially switching to a OOP/delegation system to reduce all the if statements scattered throughout. Do we want to take that approach, or is that going to be too much effort for not much gain?
   
   The change to OOP/delegation is what changed from the last commit.  Instead of adding more
   `if (optRepTypeElement.isDefined)`
   statements throughout the code I am know using the repElement suggestion you mentioned earlier in the review, which can either be the optRepTypeElement, or the element itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org