You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2009/11/12 20:43:39 UTC
[jira] Created: (SOLR-1557) shards param not parsed as a multivalue
param
shards param not parsed as a multivalue param
---------------------------------------------
Key: SOLR-1557
URL: https://issues.apache.org/jira/browse/SOLR-1557
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.4
Reporter: Hoss Man
Fix For: 1.5
the shards param currently uses some odd parsing code to split on "," ... it should both allow whitespace, and allow the shards to be specified as a multi-valued param...
http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1557) shards param not parsed as a
multivalue param
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777185#action_12777185 ]
Yonik Seeley commented on SOLR-1557:
------------------------------------
Some things make more sense as multi-valued (from the HTTP arg perspective) than others.
I hope everyone can agree that allowing "fl" to be multivalued is overkill.
Other things like "fq" make perfect sense due to the independence of the parameters and the escaping that would be needed to shove multiple in a single param.
I'm not sure I see the need or the benefit for "shard" to be multivalued though.
> shards param not parsed as a multivalue param
> ---------------------------------------------
>
> Key: SOLR-1557
> URL: https://issues.apache.org/jira/browse/SOLR-1557
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Hoss Man
> Fix For: 1.5
>
>
> the shards param currently uses some odd parsing code to split on "," ... it should both allow whitespace, and allow the shards to be specified as a multi-valued param...
> http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1557) shards param not parsed as a
multivalue param
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777168#action_12777168 ]
Hoss Man commented on SOLR-1557:
--------------------------------
bq. I wouldn't call it odd - it's the same well defined splitting code used in a few places in solr.
...hmmm, it seemed odd to me.
SolrPluginUtils.split(String) was designed for splitting params that were delimited (it's what "fl" uses) ... The shards param is using StrUtils.splitSmart() which handles quoting and backslash escape characters -- neither of which really make sense for a list of URLs.
I'm totally fine with not allowing whitespace if you had a compelling reason for excluding it -- i've been vocally opposed to supporting comma delimited values for things like this anyway but we need to leave it for back compatibility -- my main concern is that we start supporting "shard" it as a multivalued param.
> shards param not parsed as a multivalue param
> ---------------------------------------------
>
> Key: SOLR-1557
> URL: https://issues.apache.org/jira/browse/SOLR-1557
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Hoss Man
> Fix For: 1.5
>
>
> the shards param currently uses some odd parsing code to split on "," ... it should both allow whitespace, and allow the shards to be specified as a multi-valued param...
> http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1557) shards param not parsed as a
multivalue param
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777149#action_12777149 ]
Yonik Seeley commented on SOLR-1557:
------------------------------------
I wouldn't call it odd - it's the same well defined splitting code used in a few places in solr.
I'd also be against allowing whitespace, if it weren't for Jason's interesting use-case...
> shards param not parsed as a multivalue param
> ---------------------------------------------
>
> Key: SOLR-1557
> URL: https://issues.apache.org/jira/browse/SOLR-1557
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Hoss Man
> Fix For: 1.5
>
>
> the shards param currently uses some odd parsing code to split on "," ... it should both allow whitespace, and allow the shards to be specified as a multi-valued param...
> http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1557) shards param not parsed as a
multivalue param
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777321#action_12777321 ]
Hoss Man commented on SOLR-1557:
--------------------------------
bq. I'm not sure I see the need or the benefit for "shard" to be multivalued though.
the simplified specification of defaults in solrconfig.xml seems like reason enough.
but it also seems like the "defaults" vs "appends" distinction of multivalued params makes as much sense for shards as it does does for fq, etc... ie: i want this shard to always be appended to the shards list because it's the "current" shard, but let the client specify additional shards if they want to also query older/alternate content in addition.
> shards param not parsed as a multivalue param
> ---------------------------------------------
>
> Key: SOLR-1557
> URL: https://issues.apache.org/jira/browse/SOLR-1557
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Hoss Man
> Fix For: 1.5
>
>
> the shards param currently uses some odd parsing code to split on "," ... it should both allow whitespace, and allow the shards to be specified as a multi-valued param...
> http://old.nabble.com/Shards-param-accepts-spaces-between-commas--to25962879.html#a25962879
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.