Re: svn commit: r475485 - in /spamassassin/branches/jm_re2c_hacks/lib/Mail/SpamAssassin/Plugin: Check.pm RabinKarpBody.pm Rule2XSBody.pm

[Justin Mason <jm...@jmason.org>]

Michael Parker writes:
> Ugh, hardcoded package names.
> 
> You'll notice that I did away with hardcoded package names in the
> Check.pm rules functions.  This means that it can be easily subclassed
> and just work.  Not sure what the best solution for this case is but
> lets try to avoid hardcoded stuffs.

yeah, agreed -- this is still pretty hacky in this branch and that
will need to be fixed.

Ideally those classes won't call into Mail::SpamAssassin::Plugin::Check;
instead they'd have their *own* method which generates the one_line_body
match methods *on their own class* I think.

--j.